Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kubernetes aware of the LoadBalancer behaviour #1860

Open
12 tasks done
Sh4d1 opened this issue Jun 13, 2020 · 68 comments
Open
12 tasks done

Make Kubernetes aware of the LoadBalancer behaviour #1860

Sh4d1 opened this issue Jun 13, 2020 · 68 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@Sh4d1
Copy link
Member

Sh4d1 commented Jun 13, 2020

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 13, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jun 13, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 13, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2020
@Sh4d1
Copy link
Member Author

Sh4d1 commented Sep 11, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

Hi @Sh4d1

1.20 Enhancements Lead here. This KEP still seems to be a draft (it's provisional) but wanted to check-in to see if you thought this would be graduating alpha in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have an issue in the milestone

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 28, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Oct 7, 2020
@kikisdeliveryservice
Copy link
Member

Note: this provisional kep was implemented without having a compliant kep or indicating to the enhancements team that it would be in the 1.20 milestone.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Nov 10, 2020

Hey @Sh4d1 and @thockin,

👋 1.20 release lead here. We're really close to code freeze at this point (Thursday) and it seems like this KEP fell through the cracks and the process.

Based on this comment in the PR above: kubernetes/kubernetes#92312 (comment) can we not land this in 1.20 and instead target 1.21?

There are few things w/ the KEP that really should be address:

  • It's provisional still
  • There is no test plan
  • There is no graduation criteria

Looks like there is also a PR to update the KEP https://github.com/kubernetes/enhancements/pull/2134/files that addresses this stuff, however it also marks it as implemented and targets 1.21. Typically, we set to implemented only after the release.

Can we circle back around on this and agree that we should try to land this in 1.21 at this point? We've already got a lot of content for the release so far (sig-docs has their work cut out for themselves!!!), we're two days out from code freeze, we have these disconnects mentioned above?

@Sh4d1
Copy link
Member Author

Sh4d1 commented Nov 11, 2020

@jeremyrickard just opened kubernetes/kubernetes#96454 to revert it, sorry again!
And updated #2134 to set it as implentable instead of implemented

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sh4d1
Copy link
Member Author

Sh4d1 commented Apr 10, 2021

/reopen

@k8s-ci-robot
Copy link
Contributor

@Sh4d1: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thockin
Copy link
Member

thockin commented May 8, 2024

This went beta in 30. GA in 31? Or wait for 32?

@thockin thockin removed the lead-opted-in Denotes that an issue has been opted in to a release label May 8, 2024
@rikatz
Copy link
Contributor

rikatz commented May 8, 2024

I am not sure if I will be able to work through it to GA for 31

@danwinship and @aojea I've seen some movement of this and KinD cloud provider, any feedback there?

I will get some feedback internally as well

@RyanAoh do you wanna take over back for .30?

@aojea
Copy link
Member

aojea commented May 8, 2024

@danwinship and @aojea I've seen some movement of this and KinD cloud provider, any feedback there?

@danwinship is going to add the feature to e2e tests and we are going to test it in the CI with cloud provider kind, that now uses envoy ... I think this testing can give us good confidence ... but maybe waiting one release in beta is not. bad option

@rikatz
Copy link
Contributor

rikatz commented May 8, 2024

Agreed. Tim, let's target for .32 then :)

@thockin thockin modified the milestones: v1.30, v1.32 May 8, 2024
@thockin
Copy link
Member

thockin commented May 8, 2024

ACK. Flagged to re-evaluate in 32

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2024
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2024
@thockin
Copy link
Member

thockin commented Aug 29, 2024

@rikatz @RyanAoh - how does this look for 1.32?

@RyanAoh
Copy link
Member

RyanAoh commented Aug 29, 2024

OK, I would promote it to GA in 1.32.

@rikatz
Copy link
Contributor

rikatz commented Aug 29, 2024

Thanks @RyanAoh !

I will watch it, let me know if you need something from me!

@aojea
Copy link
Member

aojea commented Aug 29, 2024

Dan and I added way more coverage with cloud-provider-kind so I think we are good to go

@thockin
Copy link
Member

thockin commented Sep 12, 2024

Can I get a quick update? Is someone on the hook for a PR to promote this?

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 12, 2024
@rikatz
Copy link
Contributor

rikatz commented Sep 12, 2024

I am not, @RyanAoh is in charge of this one :)

@RyanAoh
Copy link
Member

RyanAoh commented Sep 13, 2024

@thockin I'm on it and I'll submit the PR(codes, docs and the PRR) this weekend.

@tjons
Copy link
Contributor

tjons commented Sep 29, 2024

Hello @RyanAoh 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • [] KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

To track this KEP for enhancements freeze:

  • [] the KEP readme is missing the Implementation History section. Once you update this and populate the section we can track this for enhancements freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@RyanAoh
Copy link
Member

RyanAoh commented Oct 3, 2024

@tjons The Implementation History section has been added to the kep readme.

@tjons
Copy link
Contributor

tjons commented Oct 7, 2024

@RyanAoh with all the requirements met, this enhancement is now tracked for enhancements freeze! 🚀

@hacktivist123
Copy link

Hello @RyanAoh 👋 1.32 Docs Shadow here.

Does this enhancement work planned for 1.32 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@rytswd
Copy link
Member

rytswd commented Oct 16, 2024

Hi @RyanAoh 👋 -- this is Ryota (@rytswd) from the v1.32 Communications Team!

For the v1.32 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 30th Oct 2024? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
  • Monday, 25th Nov: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@hacktivist123
Copy link

Hello, @RyanAoh 👋 1.32 Docs Shadow here.

This is just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday, Oct 24 at 18:00 PDT.
Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Status: Tracked for enhancements freeze
Status: Beta
Development

No branches or pull requests