-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add blog for feature LoadBalancerIPMode #43904
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
c06030f
to
ba7ce92
Compare
/sig network |
Hi. I'm afraid this PR should target main, not dev-1.29. Even if the announcement is related to Kubernetes v1.29 /hold |
7574d18
to
24d0461
Compare
Hi @RyanAoh , here Communication Team 1.29, the deadline to the feature blog be ready to review was this Friday, Nov 17th, the proposal publish date will be Dec 18th. cc: @a-mccarthy @kcmartin @James-Quigley @kubernetes/sig-docs-blog-owners: Blog scheduled: Dec 18th, Publication Order Nro:6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to unhold once the date (check the path and the front matter) matches the assigned date, 2023-12-18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date both in the file path and front matter have been updated to 2023-12-18.
content/en/blog/_posts/2023-11-13-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-11-13-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
7a698c8
to
a061e7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback.
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
transmitting packets to the node. In the ipvs mode of kube-proxy, | ||
there is a problem that health checks from the load balancer never return as the IP is bound to an interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transmitting packets to the node. In the ipvs mode of kube-proxy, | |
there is a problem that health checks from the load balancer never return as the IP is bound to an interface. | |
transmitting packets to the node. In the ipvs mode of kube-proxy, | |
there is a problem that health checks from the load balancer never return (the health checks fail | |
as the associated listening socket is bound to an interface that the load balancer cannot reach). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The load balancer can reach the listening socket but the reply packets can not out the node. I chane the description here. PTAL.
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
This blog introduces `LoadBalancerIPMode`, a new alpha feature in Kubernetes 1.29. | ||
It provides a configurable approach to define how service implementations, | ||
exemplified in this blog by kube-proxy, | ||
handle traffic from pods to the `service.status.loadbalancer.ingress.ip` within the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blog introduces `LoadBalancerIPMode`, a new alpha feature in Kubernetes 1.29. | |
It provides a configurable approach to define how service implementations, | |
exemplified in this blog by kube-proxy, | |
handle traffic from pods to the `service.status.loadbalancer.ingress.ip` within the cluster. | |
This blog introduces a new alpha feature in Kubernetes 1.29. | |
It provides a configurable approach to define how Service implementations, | |
exemplified in this blog by kube-proxy, | |
handle traffic from pods to the Service, within the cluster. |
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
Given that `EnsureLoadBalancer` returns a `LoadBalancerStatus`, | ||
the `ipMode` field can be set by the cloud-controller-manager before returning the status. | ||
It is more appropriate to delegate this decision to cloud providers through the cloud-controller-manager | ||
rather than relying on end users, who may not be familiar with these technical details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd skip this:
Given that `EnsureLoadBalancer` returns a `LoadBalancerStatus`, | |
the `ipMode` field can be set by the cloud-controller-manager before returning the status. | |
It is more appropriate to delegate this decision to cloud providers through the cloud-controller-manager | |
rather than relying on end users, who may not be familiar with these technical details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing this article.
This PR has missed the deadline for PRs to be ready for review; you should promptly address the pending feedback. This article is at risk of being omitted from post-release comms.
@sftim Sorry for not responding promptly. I have made a new commit incorporating your feedback. PTAL, thanks. |
c0b3bbb
to
7226012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Here's some feedback.
The big change to make is to write this article as if Kubernetes v1.29 has been released; we won't publish the article until the release has happened.
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
The default value is "VIP", meaning that traffic delivered to the node | ||
with the destination set to the load balancer's IP and port will be redirected to the backend service by kube-proxy. | ||
This preserves the existing behavior of kube-proxy. | ||
The "Proxy" value is intended to prevent kube-proxy from binding the Load Balancer IP to the node in both ipvs and iptables modes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Proxy" value is intended to prevent kube-proxy from binding the Load Balancer IP to the node in both ipvs and iptables modes. | |
The "Proxy" value is intended to prevent kube-proxy from binding the load balancer's IP address to the node | |
any mode (iptables, ipvs, nftables). |
?
What about Windows behavior? There's another operating mode for kube-proxy and the article as written makes it sound like there isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, the mode for Windows was completely overlooked. Upon checking the code, I found that it hasn't been implemented for Windows at all. This is a mistake. As the code for v1.29.0 has already been frozen. I will patch this after its release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows doesn't have nftables, but there is a kube-proxy
mode for Windows: kernelspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a k/k issue tracked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new one(kubernetes/kubernetes#122202).
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-18-kubernetes-1-29-feature-loadbalancer-ip-mode-alpha.md
Outdated
Show resolved
Hide resolved
/lgtm We can publish this article as it stands. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: afa66e8f70367f93702e35f607382128bc43c36a
|
/hold cancel |
Blog for new feature LoadBalancerIPMode.
PR link: kubernetes/kubernetes#119937
KEP issue: kubernetes/enhancements#1860