Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2923: update test plan and milestone for RBD CSI migration #3358

Merged
merged 1 commit into from
Jun 12, 2022
Merged

KEP-2923: update test plan and milestone for RBD CSI migration #3358

merged 1 commit into from
Jun 12, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jun 8, 2022

Signed-off-by: Humble Chirammal hchiramm@redhat.com

One-line PR description: Update test template and milestone
Issue Link: #2923

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 8, 2022
@humblec
Copy link
Contributor Author

humblec commented Jun 8, 2022

Cc @xing-yang
Cc @Jiawei0227

@humblec humblec force-pushed the rbd-migration branch 3 times, most recently from ff192c2 to 8017d17 Compare June 8, 2022 13:34
@humblec
KEP-2923: update test plan and milestone for RBD CSI migration
7f908cc 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec requested a review from xing-yang June 9, 2022 15:35
@humblec
Copy link
Contributor Author

humblec commented Jun 9, 2022

@xing-yang I have added the unit tests and e2e part.. ptal .thanks

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 62505f6 into kubernetes:master Jun 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 12, 2022
@rhockenbury rhockenbury mentioned this pull request Jun 15, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@humblec @xing-yang @k8s-ci-robot