Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2923: update test plan and milestone for RBD CSI migration #3358

Merged
merged 1 commit into from
Jun 12, 2022
Merged

KEP-2923: update test plan and milestone for RBD CSI migration #3358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion keps/sig-storage/2923-csi-migration-ceph-rbd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
<!-- toc -->
- [Summary](#summary)
- [New Feature Gates](#new-feature-gates)
- [Design Details](#design-details)
- [Test Plan](#test-plan)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
- [Integration tests](#integration-tests)
- [e2e tests](#e2e-tests)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Implementation History](#implementation-history)
<!-- /toc -->
Expand Down Expand Up @@ -35,6 +41,35 @@ used as described in its parent KEP. For all other contents, please refer to the
on kubelet and treat Ceph RBD CSI migration as already complete. And directly redirect traffic to CSI
driver for all rbd related operations.

## Design Details

### Test Plan

[X] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

##### Prerequisite testing updates

No additional tests are needed, rather the issue is orchestrating CSI driver
deployment for prow jobs. This means that it is not possible to run any test for
RBD in k/k repository.

##### Unit tests

The unit tests for RBD translation lib available [here](https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/rbd_test.go)
will be validated.

##### Integration tests

N/A

##### e2e tests

Support for tests after RBD migration will be covered by the subjected
RBD CSI driver which is available [here](https://github.com/ceph/ceph-csi/blob/devel/e2e/rbd.go#L426).
Addition to above, in-tree RBD driver tests available [here](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/in_tree.go#L488)
also cover the e2e part of this feature.

## Production Readiness Review Questionnaire

Expand All @@ -50,6 +85,6 @@ Major milestones for Ceph RBD in-tree plugin CSI migration:

- 1.23
- Ceph RBD CSI migration to Alpha
- 1.24
- 1.25
- Ceph RBD CSI migration to Beta, off by default

4 changes: 2 additions & 2 deletions keps/sig-storage/2923-csi-migration-ceph-rbd/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ stage: beta
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.24"
latest-milestone: "v1.25"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.23"
beta: "v1.24"
beta: "v1.25"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down