Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4210: retarget to beta for 1.30 #4426

Merged
merged 1 commit into from
Feb 7, 2024
Merged

KEP-4210: retarget to beta for 1.30 #4426

merged 1 commit into from
Feb 7, 2024

Conversation

haircommander
Copy link
Contributor

  • One-line PR description:
  • Issue link:
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2024
SergeyKanzhelev
SergeyKanzhelev reviewed Jan 23, 2024
View reviewed changes
keps/sig-node/4210-max-image-gc-age/README.md Outdated
@@ -208,12 +208,13 @@ Additional tests will be added to this file to cover the garbage collection e2e.

- Configuration field added to the Kubelet (disabled by default)
- Feature supported by Kubelet Image Manager
- Unit tests and e2e tests added
- Unit tests
- Add a metric `kubelet_image_garbage_collected_total` which tracks the number of images the kubelet is GC'ing through any mechanism.

#### Beta

- Gather feedback from users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think this will be met in 1.30 as a beta requirement? Will we be able to collect feedback from users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah tbh we don't really have a lot of feedback. I removed it as a requirement, does that make sense to do?

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jan 23, 2024
Open
8 tasks
@kannon92
Copy link
Contributor

kannon92 commented Jan 30, 2024 •
edited
Loading

/lgtm
I'd probably update the description with more details. Let's at least link it to the #4210
/assign @SergeyKanzhelev @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
enj
enj reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRR shadow

keps/sig-node/4210-max-image-gc-age/README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@haircommander
KEP-4210: retarget to beta for 1.30
706d265 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, johnbelamaric, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d45e7cc into kubernetes:master Feb 7, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@enj enj enj left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mrunalp mrunalp mrunalp approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@mrunalp mrunalp

@kannon92 kannon92

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
7 participants
@haircommander @kannon92 @johnbelamaric @k8s-ci-robot @mrunalp @enj @SergeyKanzhelev