Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft KEPs for out-of-tree cloud providers #735

Merged

Conversation

andrewsykim
Copy link
Member

Drafted up a KEP template we'll be using for tracking out-of-tree cloud provider enhancements for v1.14. Hoping to get this PR merged ASAP and then delegating the TODOs in each KEP to the respective provider SIGs (AWS, Azure, GCE, IBM, OpenStack, VMware).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/pm approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 28, 2019
---
title: Support Out-of-Tree AWS Cloud Provider
authors:
- @andrewsykim
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @d-nishi @mcrute to update AWS KEP once the PR is merged

---
title: Support Out-of-Tree Azure Cloud Provider
authors:
- @andrewsykim
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @justaugustus @khenidak to update SIG Azure KEP once this PR is merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and @lachie83 :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file put under sig-azure directory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim @feiskyer -- I think when someone picks one of the templates up, they can maybe:

  • Move the template into the relevant SIG directory
  • Update the [top-level out-of-tree KEP}(https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/2019-01-25-removing-in-tree-providers.md) to include a link to the SIG-specific one (in the same PR)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, make sense

Copy link
Member Author

@andrewsykim andrewsykim Jan 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that works for me, will leave the file here for now in this PR then :)

---
title: Support Out-of-Tree GCE Cloud Provider
authors:
- @andrewsykim
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cheftako to update this KEP once this PR is merged

---
title: Support Out-of-Tree IBM Cloud Provider
authors:
- @andrewsykim
Copy link
Member Author

@andrewsykim andrewsykim Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rtheis @spzala to update this KEP once this PR is merged

---
title: Support Out-of-Tree OpenStack Cloud Provider
authors:
- @andrewsykim
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dims @hogepodge to update this KEP once this PR is merged .

---
title: Support Out-of-Tree vSphere Cloud Provider
authors:
- @andrewsykim
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @frapposelli @cantbewong to update this KEP once this PR is merged

@andrewsykim
Copy link
Member Author

cc @claurence @spiffxp @lledru v1.14 enhancement leads

These KEPs are for:
#667
#631
#671
#668
#670
#668

- @andrewsykim
owning-sig: sig-cloud-provider
participating-sigs:
- sig-aws
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sig-azure

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KEP filename should be YYYYMMDD-kep-title.md

@andrewsykim
Copy link
Member Author

Comments addressed PTAL :)

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants