Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KEP for out-of-tree vSphere cloud provider #767

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Update KEP for out-of-tree vSphere cloud provider #767

merged 1 commit into from
Jan 30, 2019

Conversation

frapposelli
Copy link
Member

Update the KEP from draft doc published with #735, this KEP tracks issue #670

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/pm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2019
@frapposelli frapposelli changed the title (WIP) Update KEP for out-of-tree vSphere cloud provider Update KEP for out-of-tree vSphere cloud provider Jan 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2019
@frapposelli
Copy link
Member Author

/assign @cantbewong @andrewsykim @dvonthenen

@k8s-ci-robot
Copy link
Contributor

@frapposelli: GitHub didn't allow me to assign the following users: cantbewong.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cantbewong @andrewsykim @dvonthenen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frapposelli
Copy link
Member Author

@cantbewong @andrewsykim @dvonthenen PTAL for review and approval

@frapposelli frapposelli mentioned this pull request Jan 30, 2019
Closed
@davidvonthenen
Copy link

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019
andrewsykim
andrewsykim reviewed Jan 30, 2019
View reviewed changes
keps/sig-cloud-provider/20190125-out-of-tree-vsphere.md

### Graduation Criteria

TODO for SIG-VMware
This feature is complete and will be ready for graduation with release 1.14.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure what "graduation" for KEP means here. Does it mean #670 is GA? cc @justaugustus might know?

@andrewsykim
Copy link
Member

@frapposelli lgtm, can you flip the status to implementable?

@hogepodge
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dvonthenen, frapposelli, hogepodge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@frapposelli
Copy link
Member Author

/status implementable

@k8s-ci-robot k8s-ci-robot merged commit eb2b103 into kubernetes:master Jan 30, 2019
@andrewsykim andrewsykim mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@hogepodge hogepodge Awaiting requested review from hogepodge

@jagosan jagosan Awaiting requested review from jagosan

Assignees

@hogepodge hogepodge

@andrewsykim andrewsykim

@davidvonthenen davidvonthenen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frapposelli @k8s-ci-robot @davidvonthenen @andrewsykim @hogepodge @justaugustus