Webhook Conversion for Custom Resources

[deads2k]

Feature Description

• One-line feature description (can be used as a release note): Support for webhook conversion for Custom Resources.
• Primary contact (assignee): @mbohlool
• Responsible SIGs: SIG API Machinery
• Design proposal link (community repo): KEP for CRD conversion webhook community#2420
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • @nikhita
  • @sttts
  • @lavalamp
• Approver (likely from SIG/area to which feature belongs):
  • @deads2k
  • @lavalamp
• Feature target (which target equals to which milestone):
  • Alpha release target (1.13)
  • Beta release target (TBD)
  • Stable release target (TBD)

[deads2k]

@kacole2 this is an issue that can have the correct stage instead of extending an old issue that would make it confusing.

[justaugustus]

Thanks for the update, @deads2k! We've added this to 1.12 tracking.

/kind feature

[zparnold]

Hey there! @deads2k I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[justaugustus]

@deads2k --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[mbohlool]

@justaugustus I am going to ask for an exception for this feature.

[tpepper]

@kubernetes/sig-api-machinery-api-reviews can ya'll please comment as to whether you support this exception? https://groups.google.com/d/topic/kubernetes-milestone-burndown/CGiB__LAyzU/discussion

From my perspective it's a NO for the 1.12 release. We can't cherry pick a feature into the release on release day. Even if it's alpha and gated.

[deads2k]

@kubernetes/sig-api-machinery-api-reviews can ya'll please comment as to whether you support this exception? https://groups.google.com/d/topic/kubernetes-milestone-burndown/CGiB__LAyzU/discussion

From my perspective it's a NO for the 1.12 release. We can't cherry pick a feature into the release on release day. Even if it's alpha and gated.

I understand your reluctance to try to pick changes that late in the release cycle. Looking at it objectively, I can see that I'd want the same rules applied to other sigs that wanted changes and extensions that late in the cycle.

I would push harder, but I think we even lost consensus on the behavior of the API (defaulting: discussion between Jordan and Daniel). Near as I can tell, neither convinced the other and I was swayed by Jordan's argument for the usage of overrides and it's comparison to Pods.

[tpepper]

@deads2k thanks for the update. Please "/milestone clear" on existing issues and PRs around this. And is there any additional work needing backed out from an interim pre-release state? We'd had a question on the release team as to whether any merged changes around this feature might actually be impacting release blocking test cases.

[lavalamp]

I agree w/ David and I regret contributing to the loss of consensus on the API (though I'm not sure what else I could have done).

[kacole2]

this has been updated to reflect in the spreadsheet

[spiffxp]

@mbohlool @deads2k @lavalamp is this still planned for v1.13? what work if any is being done in k/k for this?

[spiffxp]

Is this related to or dependent on defaulting and pruning for CRD's? #575

[claurence]

@deads2k there has been no communication on the status but I see @spiffxp has attached a current k/k PR. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me know where we stand. Thanks!

[liggitt]

work for this feature is in progress, under review, and anticipated to be completed

bugfix:

• Fix custom resource handler in-memory version kubernetes#70087

design:

• Add per version field section to custom resource webhook conversion KEP community#2737

implementation PRs:

• CRD Conversion API Changes kubernetes#67795
• CRD webhook conversion kubernetes#67006
• CRD supports multi-version Subresources and AdditionalPrintColumns kubernetes#67521

[kacole2]

@liggitt @roycaihw @sttts, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[roycaihw]

@kacole2 the KEP that tracks Graduation Criteria about promoting this feature to Beta in 1.15 is merged

[simplytunde]

Hey @mbohlool Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[simplytunde]

@roycaihw @mbohlool The placeholder PR against k8s.io dev-1.15 is due Thursday May 30th.

[kacole2]

Hi @liggitt @roycaihw @sttts @mbohlool . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[sttts]

Docs PR for 1.15: kubernetes/website#14583

@deads2k can you update the issue description?

[kacole2]

Hi @liggitt @roycaihw @sttts @mbohlool, today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[liggitt]

there are no outstanding PRs for this release, and the docs PR is open

[liggitt]

I take it back, there is a single bugfix PR we're tracking: kubernetes/kubernetes#78523

[liggitt]

/milestone v1.16
/stage stable

[rbitia]

Hi @@mbohlool & @roycaihw, I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[roycaihw]

@rbitia Yes, it's going to be graduating stable in 1.16.

[VineethReddy02]

Hi @mbohlool & @roycaihw, I'm the v1.16 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Thanks!

[kacole2]

@liggitt @mbohlool @roycaihw code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Stable? I see kubernetes/kubernetes#78523 is already merged.

[liggitt]

kubernetes/kubernetes#81965 is the only outstanding PR

[liggitt]

docs ready for review in kubernetes/website#15982

[liggitt]

Released as stable in v1.16.0

Post-GA work tracked in https://github.com/orgs/kubernetes/projects/28

/close

[k8s-ci-robot]

@liggitt: Closing this issue.

In response to this:

Released as stable in v1.16.0

Post-GA work tracked in https://github.com/orgs/kubernetes/projects/28

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.