Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD webhook conversion #67006

Merged
merged 4 commits into from
Nov 10, 2018
Merged

CRD webhook conversion #67006

merged 4 commits into from
Nov 10, 2018

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Aug 6, 2018 •
edited
Loading

This PR is ready for review. I plan to bring parts of it (specially the refactoring in first commits) into a new PR. What is intentionally missing from this PR to make it smaller is multi-scheme and multi-print-column etc. support that will be done in a separate PR.

The PR has an end to end test with a nice image that can be used as a reference to implement conversion webhooks (it has separate framework and user code). I will use that for documentation and kubebuilder support.

Add support for CRD conversion webhook

Related PRs and Issues

@mbohlool mbohlool self-assigned this Aug 6, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 6, 2018
@k8s-ci-robot k8s-ci-robot requested review from erictune and luxas August 6, 2018 07:39
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2018
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch 2 times, most recently from 3f62356 to 0635548 Compare August 7, 2018 02:05
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 7, 2018
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from 0635548 to 4a5cbfb Compare August 16, 2018 19:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2018
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from 4a5cbfb to ef3ac77 Compare August 16, 2018 19:43
@mbohlool mbohlool changed the title [WIP] CRD webhook conversion CRD webhook conversion Aug 16, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 16, 2018
@deads2k
Copy link
Contributor

deads2k commented Aug 21, 2018

Can you break Refactor addmission webhook hook client to a util package into a separate commit and move it into the client-go library instead of apimachinery? I think I'm gathering that as I move down commits, you'll be re-using this package for the connection from teh apiextensions server.

@deads2k
Copy link
Contributor

deads2k commented Aug 21, 2018

The types commit appears to match the KEP. Can you break it out into a separate pull to help focus the api-review ?

@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from 90a5fae to 60d5c67 Compare August 23, 2018 01:19
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2018
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from 5427a77 to 655af7c Compare November 9, 2018 20:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2018
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from 655af7c to 3f89267 Compare November 9, 2018 21:14
liggitt
liggitt reviewed Nov 9, 2018
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Show resolved Hide resolved
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter.go Outdated Show resolved Hide resolved
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch 3 times, most recently from 4e2f96b to df39d68 Compare November 9, 2018 22:55
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from df39d68 to da6fb5f Compare November 9, 2018 23:10
@mbohlool mbohlool force-pushed the crd_webhook_conversion branch from da6fb5f to d51d016 Compare November 9, 2018 23:57
@mbohlool
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@liggitt
Copy link
Member

liggitt commented Nov 10, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2018
@liggitt
Copy link
Member

liggitt commented Nov 10, 2018

staging/src/k8s.io/apiextensions-apiserver needs approval by @sttts

@sttts
Copy link
Contributor

sttts commented Nov 10, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mbohlool, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 97baad3 into kubernetes:master Nov 10, 2018
@alvaroaleman alvaroaleman mentioned this pull request Nov 12, 2018
Closed
@liggitt liggitt mentioned this pull request Nov 20, 2018
Merged
@deads2k deads2k mentioned this pull request Nov 26, 2018
Closed
@liggitt liggitt mentioned this pull request Mar 6, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Aug 23, 2019
Merged
@liggitt liggitt mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@roycaihw roycaihw roycaihw left review comments

@caesarxuchao caesarxuchao caesarxuchao left review comments

@liggitt liggitt liggitt left review comments

@sttts sttts sttts left review comments

@erictune erictune erictune approved these changes

@luxas luxas Awaiting requested review from luxas

Assignees

@liggitt liggitt

@mbohlool mbohlool

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/custom-resources cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.