Add ServiceExtension CRD lifecycle management and empty spec definition #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
MrHohn
force-pushed
the
serviceextension-crd-backup
branch
from
39146f1 to
b855df8
Compare
|
Added some prune options in Gopkg.toml to delete unused and test files. PR is ready for review. |
k8s-ci-robot
removed
the
do-not-merge/hold
MrHohn
force-pushed
the
serviceextension-crd-backup
branch
2 times, most recently
from
b3159fd to
c4c7e15
Compare
Will remove this and re-vendor as kubernetes/kubernetes#61743 was merged. |
MrHohn
force-pushed
the
serviceextension-crd-backup
branch
from
c4c7e15 to
992cf0a
Compare
|
/test pull-ingress-gce-test |
|
govet is complaining about the auto-generated clent codes. FIled kubernetes/sample-controller#16. |
|
Seems like a fix is pending: kubernetes/kubernetes#60584 |
|
Added a commit to manually fix govet in generated client. |
|
Test passed and changed base branch to |
- Ensure (create/update) ServiceExtension CRD on GLBC startup. - Gate ServiceExtension logic behind a flag.
… deep-copy functions
MrHohn
force-pushed
the
serviceextension-crd-backup
branch
from
72db918 to
b19245a
Compare
|
@nicksardo @rramkumar1 Rebased PR and changed to target master. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for ServiceExtension implementation. This hasn't touched any GLBC workflow. Just added CRD create/update logic and an empty spec definition & code-gen stuffs. New code is gated behind a flag.
NOTE: Code-gen scripts are derived from https://github.com/kubernetes/sample-controller. Longer-term we might want https://github.com/kubernetes-sigs/kubebuilder, but would like to get this in first.
P.S.
dep ensure -updateseems to pull a lot more things into vendor, not sure if I did it right. Dep version is v0.4.1.@bowei @nicksardo @rramkumar1 @G-Harmon @nikhiljindal