Bake ServiceExtension into GLBC workflow #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure (create/update) ServiceExtension CRD on GLBC startup. - Gate ServiceExtension logic behind a flag.
… deep-copy functions
k8s-ci-robot
added
do-not-merge/hold
|
I would recommend you just have a separate PR for vendoring. |
Yeah I'd like to, though without updating the import in codes, dep might not pull in the new dependencies :/ |
|
Closing this for now, the workflow modification are subject to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR depends on #163 (thinking of not distracting folks). Please only look at the last commit if you'd like to take a glance before that is merged.
This makes ServiceExtension create/update/delete trigger ingress sync. Also, the corresponding ServiceExtension will be save in
backends.ServicePortif a service references it. This doesn't have actual impact on LB configuration yet.Logic is gated behind a flag.
/hold