Spelling #1819

jsoref · 2022-09-15T22:21:24Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@c5eb7ab#commitcomment-84112661

The action reports that the changes in this PR would make it happy: jsoref@7314d9a

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

k8s-ci-robot · 2022-09-15T22:21:32Z

Welcome @jsoref!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-09-15T22:21:33Z

Hi @jsoref. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsoref

Most corrections suggested by Google Sheets, all fault mine.

jsoref · 2022-09-15T22:22:00Z

CHANGELOG.md

@@ -400,7 +400,7 @@
 **Merged pull requests:**

 - Cherrypick \#1105 into Release-1.9 [\#1121](https://github.com/kubernetes/ingress-gce/pull/1121) ([freehan](https://github.com/freehan))
- Cherrpick \#1119 \[Force send Enable field for LogConfig\] into release-1.9 [\#1120](https://github.com/kubernetes/ingress-gce/pull/1120) ([skmatti](https://github.com/skmatti))


Some projects don't like changing changelogs. I'm happy to drop any changes (by commit, file, path, etc.)

jsoref · 2022-09-15T22:22:49Z

cmd/e2e-test/asm_test.go

@@ -41,9 +41,9 @@ func TestASMConfig(t *testing.T) {
 			},
 			{
 				desc:                "Invalid ConfigMap filed equals to disable",
-				configMap:           map[string]string{"enable-unknow-feild": "INVALID1"},


Interestingly the spell checker didn't notice unknow... oh well.

jsoref · 2022-09-15T22:23:20Z

cmd/e2e-test/backend_config_test.go

-			t.Fatalf("Failed to unmarshall backendconfig %s into v1beta1: %v", bcKey, err)
+			t.Fatalf("Failed to unmarshal backendconfig %s into v1beta1: %v", bcKey, err)


projects can disagree on this spelling, but this project almost exclusively uses the shorter spelling.

jsoref · 2022-09-15T22:24:18Z

cmd/e2e-test/draining_test.go

-	drainingTransitionPollTimeout = 15 * time.Minute
-	drainingTansitionPollInterval = 30 * time.Second
+	drainingTransitionPollTimeout  = 15 * time.Minute
+	drainingTransitionPollInterval = 30 * time.Second


I didn't run a code formatter in general, but i did a quick ski and for files where I guessed the linter would hate me, I let VSCode rewrite the file.

Do note that VSCode does not like the indentation of at least one Markdown file, so I'm not particularly eager to let it micromanage the entire world.

jsoref · 2022-09-15T22:25:05Z

cmd/e2e-test/upgrade/v2frontendnamer.go

-// to use v1 naming naming scheme when master is upgraded to a gke version that use v1.8.
+// to use v1 naming scheme when master is upgraded to a gke version that use v1.8.


I'm still getting used to this detector, but I believe I'm right...

jsoref · 2022-09-15T22:37:23Z

pkg/neg/syncers/utils_test.go

-	negCloud := negtypes.NewFakeNetworkEndpointGroupCloud("test-subnetwork", "test-newtork")
+	negCloud := negtypes.NewFakeNetworkEndpointGroupCloud("test-subnetwork", "test-network")


It's possible this is intentional, but it didn't seem like it, and, as w/ an earlier change, I encourage projects to use things which are clearly intentional errors as opposed to typos when testing divergence even when the idea is to simulate typos. (Most projects have too many natural typos, and it's really hard to tell them apart from the intentional ones.)

jsoref · 2022-09-15T22:38:25Z

pkg/storage/configmaps_test.go

-func TestFakeConfigMapVaule(t *testing.T) {
+func TestFakeConfigMapValue(t *testing.T) {


I would generally not make a change like this in a go file that wasn't _test because that'd be a public API, but as this is _test, I'm hoping it isn't a problem.

jsoref · 2022-09-15T22:38:34Z

pkg/storage/doc.go

-//    fact in a majority of cases (ubernetes, tests, multiple gke clusters in
+//    fact in a majority of cases (kubernetes, tests, multiple gke clusters in


jsoref · 2022-09-15T22:38:58Z

pkg/utils/namer/namer.go

-	// to handle namespace conflicts in the Ubernetes context.
+	// to handle namespace conflicts in the Kubernetes context.


jsoref · 2022-09-15T22:41:04Z

pkg/utils/namer/serviceattachmentnamer.go

-	// - 5 (hyphn connectors) = 39
+	// - 5 (hyphen connectors) = 39


There were two distinct typos of hyphen w/in the past couple of files. I'm always concerned that something might be a brand as opposed to a typo (e.g. Siemplify)

panslava · 2022-09-16T12:34:22Z

Thank you a lot for your changes,

Can I ask you to squash commits, and have all changes in a single commit, with good commit message?

jsoref · 2022-09-16T14:12:16Z

If you're happy with the changes, I'm happy to squash. As the CI hasn't run yet, I have much less faith than I would normally...

My default message would be something like:

Spelling

* word
* word
*  ...

Possibly with a signed-off-by.

But, I'll check to see if there's some obvious style bits I should incorporate...

jsoref · 2022-09-16T15:49:08Z

This commit didn't have anything fancy in its commit message: bcbe0b9, so, I went w/ the above...

panslava · 2022-09-18T16:50:21Z

/ok-to-test

jsoref · 2022-10-26T15:29:03Z

@panslava: is there something I can do to help this along? periodically rebasing/merging isn't a fun adventure...

panslava

Hey @jsoref , thank you for your change and sorry it took a while to look into it

In general it feels fine, but can we not change "non-existent" to "nonexistent" ?

* addresses * alpha * annotation * applied * asserting * attachment * attempts * attributes * available * backoff * before * binary * building * bytes-for * cherrypick * cleaned-up * cluster * comparison * condition * config * config-map * container * controller * create * created * custom * daemon * default * deletion * description * destination * discrepancy * do-not * ellipsis * empty * enabled * endpoint * existence * exists * expect * failed * fails * feature * field * for * gcloud * getting * github * given * global * has * have * healthcheck * healthz requests * however * https * https proxy * hyphen * identify * illegal * implements * initialize * instance * instantiated * instead * internal * invalid * kubernetes * labels * lifecycle * lookup * maintain * map-from * matched * metrics * modularity * msg * name * name-space * namespace * naming * network * occurring * omitted * ongoing * overridden * overwrite * path matcher * ports * preexisting * prefix * provided * querying * rate limiting * reclamation * referring * register * regular * replicas * require * resetting * resource * responses * retrieve * retrieving * script * service * shouldn't * specified * stickiness * stuck * switch * syncer * target * targeting * the * throughput * transition * troubleshooting * true * truncated * unable * uneven * unexpected * unknown * unmarshal * unready * unstructured * up to * update * updated * upgrading * utilization balancing * value * verifies * waiting * will * with Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2022-11-01T21:26:17Z

@panslava: dropped -- do note that it's much easier to drop before squashing.

panslava · 2022-11-01T23:51:33Z

/lgtm

thank you, sorry again for some delay

k8s-ci-robot · 2022-11-01T23:51:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsoref, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2022

k8s-ci-robot requested review from cezarygerard and thockin September 15, 2022 22:21

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2022

jsoref commented Sep 15, 2022

View reviewed changes

jsoref force-pushed the spelling branch from b82303e to 92073bb Compare September 16, 2022 15:47

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2022

jsoref force-pushed the spelling branch from 92073bb to 30f55ff Compare September 28, 2022 01:29

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022

jsoref force-pushed the spelling branch from 30f55ff to 305b604 Compare October 26, 2022 15:28

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022

jsoref force-pushed the spelling branch from 305b604 to 76da549 Compare October 28, 2022 19:25

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022

panslava reviewed Nov 1, 2022

View reviewed changes

jsoref force-pushed the spelling branch from 76da549 to a10d2ce Compare November 1, 2022 21:25

jsoref removed the request for review from cezarygerard November 1, 2022 21:26

jsoref requested review from panslava and removed request for thockin November 1, 2022 21:26

k8s-ci-robot assigned panslava Nov 1, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022

k8s-ci-robot merged commit 254936e into kubernetes:master Nov 1, 2022

jsoref deleted the spelling branch November 2, 2022 00:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #1819

Spelling #1819

jsoref commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

jsoref left a comment

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

jsoref Sep 15, 2022

panslava commented Sep 16, 2022

jsoref commented Sep 16, 2022

jsoref commented Sep 16, 2022

panslava commented Sep 18, 2022

jsoref commented Oct 26, 2022

panslava left a comment •

edited

Loading

jsoref commented Nov 1, 2022

panslava commented Nov 1, 2022

k8s-ci-robot commented Nov 1, 2022

		t.Fatalf("Failed to unmarshall backendconfig %s into v1beta1: %v", bcKey, err)
		t.Fatalf("Failed to unmarshal backendconfig %s into v1beta1: %v", bcKey, err)

		// to use v1 naming naming scheme when master is upgraded to a gke version that use v1.8.
		// to use v1 naming scheme when master is upgraded to a gke version that use v1.8.

		negCloud := negtypes.NewFakeNetworkEndpointGroupCloud("test-subnetwork", "test-newtork")
		negCloud := negtypes.NewFakeNetworkEndpointGroupCloud("test-subnetwork", "test-network")

		func TestFakeConfigMapVaule(t *testing.T) {
		func TestFakeConfigMapValue(t *testing.T) {

		// fact in a majority of cases (ubernetes, tests, multiple gke clusters in
		// fact in a majority of cases (kubernetes, tests, multiple gke clusters in

		// to handle namespace conflicts in the Ubernetes context.
		// to handle namespace conflicts in the Kubernetes context.

		// - 5 (hyphn connectors) = 39
		// - 5 (hyphen connectors) = 39

Spelling #1819

Spelling #1819

Conversation

jsoref commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panslava commented Sep 16, 2022

jsoref commented Sep 16, 2022

jsoref commented Sep 16, 2022

panslava commented Sep 18, 2022

jsoref commented Oct 26, 2022

panslava left a comment • edited Loading

Choose a reason for hiding this comment

jsoref commented Nov 1, 2022

panslava commented Nov 1, 2022

k8s-ci-robot commented Nov 1, 2022

panslava left a comment •

edited

Loading