Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1819

Merged
merged 1 commit into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@
**Merged pull requests:**

- Cherrypick \#1105 into Release-1.9 [\#1121](https://github.com/kubernetes/ingress-gce/pull/1121) ([freehan](https://github.com/freehan))
- Cherrpick \#1119 \[Force send Enable field for LogConfig\] into release-1.9 [\#1120](https://github.com/kubernetes/ingress-gce/pull/1120) ([skmatti](https://github.com/skmatti))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like changing changelogs. I'm happy to drop any changes (by commit, file, path, etc.)

- Cherrypick \#1119 \[Force send Enable field for LogConfig\] into release-1.9 [\#1120](https://github.com/kubernetes/ingress-gce/pull/1120) ([skmatti](https://github.com/skmatti))
- Update generated code for BackendConfig in release-1.9 [\#1115](https://github.com/kubernetes/ingress-gce/pull/1115) ([skmatti](https://github.com/skmatti))
- Cherry Pick \#1107 \[Wait for caches to sync before running node sync\] to release-1.9 [\#1114](https://github.com/kubernetes/ingress-gce/pull/1114) ([spencerhance](https://github.com/spencerhance))
- Cherry Pick \#1104 \[Change project permissions check from 'foo' to 'k8s-ingress-svc-acct-...\] to release-1.9… [\#1113](https://github.com/kubernetes/ingress-gce/pull/1113) ([spencerhance](https://github.com/spencerhance))
Expand Down Expand Up @@ -649,7 +649,7 @@
- Fix CreateILBSubnet\(\) logic in e2e tests [\#885](https://github.com/kubernetes/ingress-gce/pull/885) ([spencerhance](https://github.com/spencerhance))
- Fix Ingress names for ILB e2e update test [\#884](https://github.com/kubernetes/ingress-gce/pull/884) ([spencerhance](https://github.com/spencerhance))
- Refactor ingress key function and finalizer into separate package [\#883](https://github.com/kubernetes/ingress-gce/pull/883) ([skmatti](https://github.com/skmatti))
- deploy csm neg scirpt and yaml [\#882](https://github.com/kubernetes/ingress-gce/pull/882) ([cadmuxe](https://github.com/cadmuxe))
- deploy csm neg script and yaml [\#882](https://github.com/kubernetes/ingress-gce/pull/882) ([cadmuxe](https://github.com/cadmuxe))
- BugFix: Update ingress key function used for GC [\#881](https://github.com/kubernetes/ingress-gce/pull/881) ([skmatti](https://github.com/skmatti))
- Fix basic ilb test service name [\#880](https://github.com/kubernetes/ingress-gce/pull/880) ([spencerhance](https://github.com/spencerhance))
- Fix backend services whitebox test to take into account the default backend [\#878](https://github.com/kubernetes/ingress-gce/pull/878) ([rramkumar1](https://github.com/rramkumar1))
Expand Down Expand Up @@ -709,7 +709,7 @@
**Fixed bugs:**

- NEG controller should create NEG for default backend when enabled [\#767](https://github.com/kubernetes/ingress-gce/issues/767)
- Removing Node Pool from Cluster Breaks Ingress Conroller [\#649](https://github.com/kubernetes/ingress-gce/issues/649)
- Removing Node Pool from Cluster Breaks Ingress Controller [\#649](https://github.com/kubernetes/ingress-gce/issues/649)
- Ingress controller should react to node scale down event from autoscaler [\#595](https://github.com/kubernetes/ingress-gce/issues/595)
- BackendConfig OpenAPI spec [\#563](https://github.com/kubernetes/ingress-gce/issues/563)

Expand Down Expand Up @@ -811,7 +811,7 @@

**Closed issues:**

- HTTS frontend listener isn't deleted after setting ingress.allow-http: "false" annotation [\#766](https://github.com/kubernetes/ingress-gce/issues/766)
- HTTPS frontend listener isn't deleted after setting ingress.allow-http: "false" annotation [\#766](https://github.com/kubernetes/ingress-gce/issues/766)
- Backends healthchecks and expected operation [\#762](https://github.com/kubernetes/ingress-gce/issues/762)
- Update GKE self managed script [\#758](https://github.com/kubernetes/ingress-gce/issues/758)
- Deploying to GKE self managed has invalid YAML [\#755](https://github.com/kubernetes/ingress-gce/issues/755)
Expand All @@ -832,7 +832,7 @@
- Rebase of \#559 "Scaffolding for FrontendConfig" [\#753](https://github.com/kubernetes/ingress-gce/pull/753) ([spencerhance](https://github.com/spencerhance))
- Emit event if Ingress spec does not contain valid config to setup frontend resources [\#752](https://github.com/kubernetes/ingress-gce/pull/752) ([rramkumar1](https://github.com/rramkumar1))
- readiness reflector [\#748](https://github.com/kubernetes/ingress-gce/pull/748) ([freehan](https://github.com/freehan))
- Adding the /healthz handler to the 404-default-server-with-metris to … [\#747](https://github.com/kubernetes/ingress-gce/pull/747) ([vbannai](https://github.com/vbannai))
- Adding the /healthz handler to the 404-default-server-with-metrics to … [\#747](https://github.com/kubernetes/ingress-gce/pull/747) ([vbannai](https://github.com/vbannai))
- Update canonical rbac.yaml with latest, minimal bindings [\#746](https://github.com/kubernetes/ingress-gce/pull/746) ([dekkagaijin](https://github.com/dekkagaijin))
- Adding docker configuration file for the 404-server-with-metrics and … [\#745](https://github.com/kubernetes/ingress-gce/pull/745) ([vbannai](https://github.com/vbannai))
- More composite types [\#742](https://github.com/kubernetes/ingress-gce/pull/742) ([spencerhance](https://github.com/spencerhance))
Expand All @@ -844,7 +844,7 @@
**Implemented enhancements:**

- Link for the example on deploying ingress controller is not valid [\#686](https://github.com/kubernetes/ingress-gce/issues/686)
- If readiness probe is on port different than the service \(app\) port - ingress failes to sync the correct healthcheck [\#647](https://github.com/kubernetes/ingress-gce/issues/647)
- If readiness probe is on port different than the service \(app\) port - ingress fails to sync the correct healthcheck [\#647](https://github.com/kubernetes/ingress-gce/issues/647)

**Fixed bugs:**

Expand Down Expand Up @@ -931,11 +931,11 @@
- GKE BackendConfig permissions change `container.backendConfigs.get` does not exist [\#538](https://github.com/kubernetes/ingress-gce/issues/538)
- A new home for 404-server \(defaultbackend\) [\#498](https://github.com/kubernetes/ingress-gce/issues/498)
- Does not work if workers are in different subnet. [\#282](https://github.com/kubernetes/ingress-gce/issues/282)
- original http request origin and host headers are overriden [\#179](https://github.com/kubernetes/ingress-gce/issues/179)
- original http request origin and host headers are overridden [\#179](https://github.com/kubernetes/ingress-gce/issues/179)

**Merged pull requests:**

- Modify NameBelongToCluter to tolerate truncated cluster name suffix [\#650](https://github.com/kubernetes/ingress-gce/pull/650) ([freehan](https://github.com/freehan))
- Modify NameBelongToCluster to tolerate truncated cluster name suffix [\#650](https://github.com/kubernetes/ingress-gce/pull/650) ([freehan](https://github.com/freehan))
- Shorten the name of the namespace for test sandboxes [\#648](https://github.com/kubernetes/ingress-gce/pull/648) ([rramkumar1](https://github.com/rramkumar1))
- Move lone function in kubeapi.go into existing utils.go [\#644](https://github.com/kubernetes/ingress-gce/pull/644) ([rramkumar1](https://github.com/rramkumar1))
- Update CHANGELOG and version mapping for v1.4.3 [\#643](https://github.com/kubernetes/ingress-gce/pull/643) ([rramkumar1](https://github.com/rramkumar1))
Expand Down Expand Up @@ -988,7 +988,7 @@
- Add pkg/common/operator & pkg/common/typed to make resource joins much cleaner. [\#517](https://github.com/kubernetes/ingress-gce/pull/517) ([rramkumar1](https://github.com/rramkumar1))
- Add Syncer Skeleton [\#509](https://github.com/kubernetes/ingress-gce/pull/509) ([freehan](https://github.com/freehan))
- Welcome defaultbackend to the ingress-gce repo [\#503](https://github.com/kubernetes/ingress-gce/pull/503) ([jonpulsifer](https://github.com/jonpulsifer))
- Add a Backofff Handler utils [\#499](https://github.com/kubernetes/ingress-gce/pull/499) ([freehan](https://github.com/freehan))
- Add a Backoff Handler utils [\#499](https://github.com/kubernetes/ingress-gce/pull/499) ([freehan](https://github.com/freehan))

# Change Log

Expand All @@ -999,7 +999,7 @@

- GCP - Kubernetes Ingress Backend service unhealthy [\#621](https://github.com/kubernetes/ingress-gce/issues/621)
- BackendConfig security policy not enforced [\#616](https://github.com/kubernetes/ingress-gce/issues/616)
- original http request origin and host headers are overriden [\#179](https://github.com/kubernetes/ingress-gce/issues/179)
- original http request origin and host headers are overridden [\#179](https://github.com/kubernetes/ingress-gce/issues/179)

**Merged pull requests:**

Expand Down Expand Up @@ -1133,7 +1133,7 @@

**Closed issues:**

- GCE ingress stucks on "Creating ingress" status, existing ingresses don't update [\#470](https://github.com/kubernetes/ingress-gce/issues/470)
- GCE ingress stuck on "Creating ingress" status, existing ingresses don't update [\#470](https://github.com/kubernetes/ingress-gce/issues/470)
- Issue with multiple domains and SSL certificates when using ingress-gce [\#466](https://github.com/kubernetes/ingress-gce/issues/466)

**Merged pull requests:**
Expand Down Expand Up @@ -1251,7 +1251,7 @@
- Documentation fixes [\#394](https://github.com/kubernetes/ingress-gce/pull/394) ([rramkumar1](https://github.com/rramkumar1))
- Implement security policy validator for real [\#393](https://github.com/kubernetes/ingress-gce/pull/393) ([MrHohn](https://github.com/MrHohn))
- promote http2 to beta [\#382](https://github.com/kubernetes/ingress-gce/pull/382) ([agau4779](https://github.com/agau4779))
- Typo in message: SyncNetworkEndpiontGroupFailed-\>SyncNetworkEndpointGroupFailed [\#374](https://github.com/kubernetes/ingress-gce/pull/374) ([AdamDang](https://github.com/AdamDang))
- Typo in message: SyncNetworkEndpointGroupFailed-\>SyncNetworkEndpointGroupFailed [\#374](https://github.com/kubernetes/ingress-gce/pull/374) ([AdamDang](https://github.com/AdamDang))
- URLMap sync [\#356](https://github.com/kubernetes/ingress-gce/pull/356) ([nicksardo](https://github.com/nicksardo))

## [v1.2.2](https://github.com/kubernetes/ingress-gce/tree/v1.2.2) (2018-07-09)
Expand Down Expand Up @@ -1307,7 +1307,7 @@
- Fix WaitForGCLBDeletion\(\) callers [\#371](https://github.com/kubernetes/ingress-gce/pull/371) ([MrHohn](https://github.com/MrHohn))
- Update deploy script to edit copy of default backend service yaml [\#368](https://github.com/kubernetes/ingress-gce/pull/368) ([rramkumar1](https://github.com/rramkumar1))
- Add simple e2e test for CDN & IAP [\#367](https://github.com/kubernetes/ingress-gce/pull/367) ([rramkumar1](https://github.com/rramkumar1))
- Swtich to use beta HealthCheck for NEG [\#366](https://github.com/kubernetes/ingress-gce/pull/366) ([freehan](https://github.com/freehan))
- Switch to use beta HealthCheck for NEG [\#366](https://github.com/kubernetes/ingress-gce/pull/366) ([freehan](https://github.com/freehan))
- Fix order-dependency in test cases [\#364](https://github.com/kubernetes/ingress-gce/pull/364) ([anfernee](https://github.com/anfernee))
- Revendor GCE go client, cloud provider and fixes to make it work [\#362](https://github.com/kubernetes/ingress-gce/pull/362) ([freehan](https://github.com/freehan))
- Fix missing gcloud command in e2e script [\#361](https://github.com/kubernetes/ingress-gce/pull/361) ([bowei](https://github.com/bowei))
Expand All @@ -1322,7 +1322,7 @@
- merge Ingress NEG annotation and Expose NEG annotation [\#350](https://github.com/kubernetes/ingress-gce/pull/350) ([agau4779](https://github.com/agau4779))
- Add Liveness Probe for NEG controller [\#349](https://github.com/kubernetes/ingress-gce/pull/349) ([freehan](https://github.com/freehan))
- Make sure we get a BackendService after updating it to populate object fingerprint \[WIP\] [\#348](https://github.com/kubernetes/ingress-gce/pull/348) ([rramkumar1](https://github.com/rramkumar1))
- On removal of backend config name from service annotaion, ensure no existing settings are affected [\#347](https://github.com/kubernetes/ingress-gce/pull/347) ([rramkumar1](https://github.com/rramkumar1))
- On removal of backend config name from service annotation, ensure no existing settings are affected [\#347](https://github.com/kubernetes/ingress-gce/pull/347) ([rramkumar1](https://github.com/rramkumar1))
- Adds readme for e2e-tests [\#346](https://github.com/kubernetes/ingress-gce/pull/346) ([bowei](https://github.com/bowei))
- Modify IAP + CDN support to not touch settings if section in spec is missing [\#345](https://github.com/kubernetes/ingress-gce/pull/345) ([rramkumar1](https://github.com/rramkumar1))
- Delete ingress and wait for resource deletion [\#344](https://github.com/kubernetes/ingress-gce/pull/344) ([bowei](https://github.com/bowei))
Expand Down
4 changes: 2 additions & 2 deletions cmd/404-server-with-metrics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ ab -n 10000000 -c 10000 http://localhost:8080/page.html > /tmp/ab_get_test.log &

* Results
* default MAXGOPROCS = 12
* around 1K requests/sec each (GET and POST)over 2m (combine througput of 2K requests/sec)
* around 1K requests/sec each (GET and POST)over 2m (combine throughput of 2K requests/sec)
* max go routines peaked to 17K and oscillates between 5K to 15K
* server over 20M GET + POST requests

Expand Down Expand Up @@ -248,7 +248,7 @@ ab -n 10000000 -c 1000 http://localhost:8080/page.html > /tmp/ab_get_test.log &

* Results
* default MAXGOPROCS = 12
* around 18K requests/sec each (GET and POST) over 20m requests (combine througput of 36K requests/sec)
* around 18K requests/sec each (GET and POST) over 20m requests (combine throughput of 36K requests/sec)
* max go routines peaked to 1.5K and oscillates between 500 to 1.5K
* server over 20M GET requests
* http processing delay over 1m, low: 0.075ms, avg: 0.125ms and max: 0.2ms
Expand Down
18 changes: 9 additions & 9 deletions cmd/e2e-test/asm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ func TestASMConfig(t *testing.T) {
},
{
desc: "Invalid ConfigMap filed equals to disable",
configMap: map[string]string{"enable-unknow-feild": "INVALID1"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly the spell checker didn't notice unknow... oh well.

configMap: map[string]string{"enable-unknow-field": "INVALID1"},
wantASMReady: false,
wantConfigMapEvents: []string{"The map contains a unknown key-value pair: enable-unknow-feild:INVALID1"},
wantConfigMapEvents: []string{"The map contains a unknown key-value pair: enable-unknow-field:INVALID1"},
},
{
desc: "Set enable-asm to true should restart the controller",
Expand Down Expand Up @@ -124,14 +124,14 @@ func TestASMServiceAndDestinationRule(t *testing.T) {
// Different versions will be used as DestinationRule: subset
for _, deployment := range []struct {
deploymentName string
replics int32
replicas int32
version string
}{
{deploymentName: "deployment-v1", replics: 1, version: "v1"},
{deploymentName: "deployment-v2", replics: 2, version: "v2"},
{deploymentName: "deployment-v3", replics: 3, version: "v3"},
{deploymentName: "deployment-v1", replicas: 1, version: "v1"},
{deploymentName: "deployment-v2", replicas: 2, version: "v2"},
{deploymentName: "deployment-v3", replicas: 3, version: "v3"},
} {
if err := e2e.CreatePorterDeployment(s, deployment.deploymentName, deployment.replics, deployment.version); err != nil {
if err := e2e.CreatePorterDeployment(s, deployment.deploymentName, deployment.replicas, deployment.version); err != nil {
t.Errorf("Failed to create deployment, Error: %s", err)
}
}
Expand Down Expand Up @@ -163,7 +163,7 @@ func TestASMServiceAndDestinationRule(t *testing.T) {
}
if svc.inSkipNamespace {
if negStatus != nil {
t.Errorf("Service: %s/%s is in the ASM skip namespace, shoudln't have NEG Status. ASM Config: %v, NEGStatus got: %v",
t.Errorf("Service: %s/%s is in the ASM skip namespace, shouldn't have NEG Status. ASM Config: %v, NEGStatus got: %v",
sandbox.Namespace, svc.svcName, asmConfig, negStatus)
}
} else {
Expand All @@ -190,7 +190,7 @@ func TestASMServiceAndDestinationRule(t *testing.T) {
t.Run(tc.desc, func(t *testing.T) {
sandbox := s
drHost := svcName
// crossNamespace will test DestinationRules that refering a serive located in a different namespace
// crossNamespace will test DestinationRules that referring a service located in a different namespace
if tc.crossNamespace {
sandbox = sSkip
drHost = fmt.Sprintf("%s.%s.svc.cluster.local", svcName, s.Namespace)
Expand Down
2 changes: 1 addition & 1 deletion cmd/e2e-test/backend_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func TestBackendConfigAPI(t *testing.T) {
}
v1beta1BackendConfig := &backendconfigv1beta1.BackendConfig{}
if err := json.Unmarshal(bcData, v1beta1BackendConfig); err != nil {
t.Fatalf("Failed to unmarshall backendconfig %s into v1beta1: %v", bcKey, err)
t.Fatalf("Failed to unmarshal backendconfig %s into v1beta1: %v", bcKey, err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects can disagree on this spelling, but this project almost exclusively uses the shorter spelling.

}

// Create BackendConfig using v1 API and retrieve it using v1beta1 API.
Expand Down
4 changes: 2 additions & 2 deletions cmd/e2e-test/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func testBasicOS(t *testing.T, os e2e.OS) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, tc.ing.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, tc.ing.Name)

// Perform whitebox testing.
gclb, err := e2e.WhiteboxTest(ing, nil, Framework.Cloud, "", s)
Expand Down Expand Up @@ -200,7 +200,7 @@ func TestEdge(t *testing.T) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, tc.ing.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, tc.ing.Name)

// Perform whitebox testing.
gclb, err := e2e.WhiteboxTest(ing, nil, Framework.Cloud, "", s)
Expand Down
6 changes: 3 additions & 3 deletions cmd/e2e-test/draining_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ import (
)

const (
drainingTransitionPollTimeout = 15 * time.Minute
drainingTansitionPollInterval = 30 * time.Second
drainingTransitionPollTimeout = 15 * time.Minute
drainingTransitionPollInterval = 30 * time.Second
Comment on lines -38 to +39
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run a code formatter in general, but i did a quick ski and for files where I guessed the linter would hate me, I let VSCode rewrite the file.

Do note that VSCode does not like the indentation of at least one Markdown file, so I'm not particularly eager to let it micromanage the entire world.

)

func TestDraining(t *testing.T) {
Expand Down Expand Up @@ -134,7 +134,7 @@ func TestDraining(t *testing.T) {
t.Errorf("Failed to update BackendConfig ConnectionDraining settings for %s: %v", t.Name(), err)
}

if err := wait.Poll(drainingTansitionPollInterval, drainingTransitionPollTimeout, func() (bool, error) {
if err := wait.Poll(drainingTransitionPollInterval, drainingTransitionPollTimeout, func() (bool, error) {
params := &fuzz.GCLBForVIPParams{VIP: vip, Validators: fuzz.FeatureValidators(features.All)}
gclb, err = fuzz.GCLBForVIP(context.Background(), Framework.Cloud, params)
if err != nil {
Expand Down
10 changes: 5 additions & 5 deletions cmd/e2e-test/ilb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func TestILB(t *testing.T) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, tc.ing.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, tc.ing.Name)

// Perform whitebox testing.
if len(ing.Status.LoadBalancer.Ingress) < 1 {
Expand Down Expand Up @@ -334,7 +334,7 @@ func TestILBHttps(t *testing.T) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, ing.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, ing.Name)

// Perform whitebox testing.
if len(ing.Status.LoadBalancer.Ingress) < 1 {
Expand Down Expand Up @@ -624,7 +624,7 @@ func TestILBUpdate(t *testing.T) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, tc.ing.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, tc.ing.Name)

// Perform whitebox testing.
if len(ing.Status.LoadBalancer.Ingress) < 1 {
Expand Down Expand Up @@ -659,7 +659,7 @@ func TestILBUpdate(t *testing.T) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, tc.ingUpdate.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, tc.ingUpdate.Name)

// Perform whitebox testing.
if len(ing.Status.LoadBalancer.Ingress) < 1 {
Expand Down Expand Up @@ -851,7 +851,7 @@ func TestILBShared(t *testing.T) {
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, ing.Name)
t.Logf("GCLB resources created (%s/%s)", s.Namespace, ing.Name)

// Perform whitebox testing.
if len(ing.Status.LoadBalancer.Ingress) < 1 {
Expand Down
Loading