-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #1819
Spelling #1819
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,9 +41,9 @@ func TestASMConfig(t *testing.T) { | |
}, | ||
{ | ||
desc: "Invalid ConfigMap filed equals to disable", | ||
configMap: map[string]string{"enable-unknow-feild": "INVALID1"}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly the spell checker didn't notice |
||
configMap: map[string]string{"enable-unknow-field": "INVALID1"}, | ||
wantASMReady: false, | ||
wantConfigMapEvents: []string{"The map contains a unknown key-value pair: enable-unknow-feild:INVALID1"}, | ||
wantConfigMapEvents: []string{"The map contains a unknown key-value pair: enable-unknow-field:INVALID1"}, | ||
}, | ||
{ | ||
desc: "Set enable-asm to true should restart the controller", | ||
|
@@ -124,14 +124,14 @@ func TestASMServiceAndDestinationRule(t *testing.T) { | |
// Different versions will be used as DestinationRule: subset | ||
for _, deployment := range []struct { | ||
deploymentName string | ||
replics int32 | ||
replicas int32 | ||
version string | ||
}{ | ||
{deploymentName: "deployment-v1", replics: 1, version: "v1"}, | ||
{deploymentName: "deployment-v2", replics: 2, version: "v2"}, | ||
{deploymentName: "deployment-v3", replics: 3, version: "v3"}, | ||
{deploymentName: "deployment-v1", replicas: 1, version: "v1"}, | ||
{deploymentName: "deployment-v2", replicas: 2, version: "v2"}, | ||
{deploymentName: "deployment-v3", replicas: 3, version: "v3"}, | ||
} { | ||
if err := e2e.CreatePorterDeployment(s, deployment.deploymentName, deployment.replics, deployment.version); err != nil { | ||
if err := e2e.CreatePorterDeployment(s, deployment.deploymentName, deployment.replicas, deployment.version); err != nil { | ||
t.Errorf("Failed to create deployment, Error: %s", err) | ||
} | ||
} | ||
|
@@ -163,7 +163,7 @@ func TestASMServiceAndDestinationRule(t *testing.T) { | |
} | ||
if svc.inSkipNamespace { | ||
if negStatus != nil { | ||
t.Errorf("Service: %s/%s is in the ASM skip namespace, shoudln't have NEG Status. ASM Config: %v, NEGStatus got: %v", | ||
t.Errorf("Service: %s/%s is in the ASM skip namespace, shouldn't have NEG Status. ASM Config: %v, NEGStatus got: %v", | ||
sandbox.Namespace, svc.svcName, asmConfig, negStatus) | ||
} | ||
} else { | ||
|
@@ -190,7 +190,7 @@ func TestASMServiceAndDestinationRule(t *testing.T) { | |
t.Run(tc.desc, func(t *testing.T) { | ||
sandbox := s | ||
drHost := svcName | ||
// crossNamespace will test DestinationRules that refering a serive located in a different namespace | ||
// crossNamespace will test DestinationRules that referring a service located in a different namespace | ||
if tc.crossNamespace { | ||
sandbox = sSkip | ||
drHost = fmt.Sprintf("%s.%s.svc.cluster.local", svcName, s.Namespace) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,7 +185,7 @@ func TestBackendConfigAPI(t *testing.T) { | |
} | ||
v1beta1BackendConfig := &backendconfigv1beta1.BackendConfig{} | ||
if err := json.Unmarshal(bcData, v1beta1BackendConfig); err != nil { | ||
t.Fatalf("Failed to unmarshall backendconfig %s into v1beta1: %v", bcKey, err) | ||
t.Fatalf("Failed to unmarshal backendconfig %s into v1beta1: %v", bcKey, err) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. projects can disagree on this spelling, but this project almost exclusively uses the shorter spelling. |
||
} | ||
|
||
// Create BackendConfig using v1 API and retrieve it using v1beta1 API. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,8 +35,8 @@ import ( | |
) | ||
|
||
const ( | ||
drainingTransitionPollTimeout = 15 * time.Minute | ||
drainingTansitionPollInterval = 30 * time.Second | ||
drainingTransitionPollTimeout = 15 * time.Minute | ||
drainingTransitionPollInterval = 30 * time.Second | ||
Comment on lines
-38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't run a code formatter in general, but i did a quick ski and for files where I guessed the linter would hate me, I let VSCode rewrite the file. Do note that VSCode does not like the indentation of at least one Markdown file, so I'm not particularly eager to let it micromanage the entire world. |
||
) | ||
|
||
func TestDraining(t *testing.T) { | ||
|
@@ -134,7 +134,7 @@ func TestDraining(t *testing.T) { | |
t.Errorf("Failed to update BackendConfig ConnectionDraining settings for %s: %v", t.Name(), err) | ||
} | ||
|
||
if err := wait.Poll(drainingTansitionPollInterval, drainingTransitionPollTimeout, func() (bool, error) { | ||
if err := wait.Poll(drainingTransitionPollInterval, drainingTransitionPollTimeout, func() (bool, error) { | ||
params := &fuzz.GCLBForVIPParams{VIP: vip, Validators: fuzz.FeatureValidators(features.All)} | ||
gclb, err = fuzz.GCLBForVIP(context.Background(), Framework.Cloud, params) | ||
if err != nil { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects don't like changing changelogs. I'm happy to drop any changes (by commit, file, path, etc.)