-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L4 NetLB Dual-Stack Metrics #1937
Conversation
865165e
to
016300a
Compare
016300a
to
380e5d2
Compare
/retest |
380e5d2
to
555c9ba
Compare
@panslava: GitHub didn't allow me to assign the following users: czawadka. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @cezarygerard |
555c9ba
to
e4da281
Compare
/assign aojea |
b12afc1
to
ea78598
Compare
ad1b035
to
d6dc142
Compare
we discussed it at te desk |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds counting service per ipFamilies, ipFamilyPolicy and Status for L4 NetLB DualStack
As ILB and NetLB DualStack metrics store the same data, I changed type L4ILBDualStackServiceState to be just general L4DualStackServiceState
I will add PersistentError (status to report after 20 mins of errors) in the next PR for both ILB and NetLB