Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new metric status PersistentError for L4 DualStack #1944

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add new metric status PersistentError for L4 DualStack #1944

merged 1 commit into from
Feb 17, 2023

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Feb 11, 2023 •
edited
Loading

Report PersistentError if service is in Error after 20 minutes of
retries

Should be merged after NetLB Metrics #1937

/assign cezarygerard

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei February 11, 2023 13:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2023
@panslava panslava force-pushed the ilb-ipv6-slo-errors branch from a073bdb to 7e4f4ec Compare February 15, 2023 17:48
@panslava panslava changed the title Report SLO Errors only after 20 minutes for DualStack ILB Add new metric status PersistentError for L4 DualStack Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@panslava panslava force-pushed the ilb-ipv6-slo-errors branch 2 times, most recently from df9ba09 to 7f4a42d Compare February 16, 2023 14:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2023
cezarygerard
cezarygerard reviewed Feb 16, 2023
View reviewed changes
pkg/metrics/types.go Outdated Show resolved Hide resolved
@panslava panslava force-pushed the ilb-ipv6-slo-errors branch from 7f4a42d to 99df692 Compare February 16, 2023 15:30
cezarygerard
cezarygerard reviewed Feb 16, 2023
View reviewed changes
pkg/metrics/metrics.go Outdated
@@ -39,7 +39,8 @@ const (
// Env variable for ingress version
versionVar = "INGRESS_VERSION"
// Dummy float so we can used bool based timeseries
versionValue = 1.0
versionValue = 1.0
persistentErrorThreshold = 20 * time.Minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

persistentErrorThresholdTime?

pkg/metrics/types.go
type L4DualStackServiceState struct {
L4DualStackServiceLabels
// FirstSyncErrorTime specifies the time timestamp when the service sync ended up with error for the first time.
FirstSyncErrorTime *time.Time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FirstSyncTime?
you always set it, not only when error happens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is funny logic we have, but on every sync we initially set the service to Error state, and only on successfuly sync update it to success

That's why on every beggining on sync we also set FirstSyncErrorTime -- considering that service is in Error state

So I think we should keep the name

@panslava
Add new metric status PersistentError for L4 DualStack
5291909 
Report PersistentError if service is in Error after 20 minutes of
retries
@panslava panslava force-pushed the ilb-ipv6-slo-errors branch from 99df692 to 5291909 Compare February 17, 2023 16:07
@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a519348 into kubernetes:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezarygerard cezarygerard cezarygerard left review comments

@aojea aojea Awaiting requested review from aojea

@bowei bowei Awaiting requested review from bowei

Assignees

@cezarygerard cezarygerard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panslava @cezarygerard @k8s-ci-robot