Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s-cloud-provider to v1.22.0 #1991

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Bump k8s-cloud-provider to v1.22.0 #1991

merged 3 commits into from
Mar 23, 2023

Conversation

spencerhance
Copy link
Contributor

This is needed to pull in GoogleCloudPlatform/k8s-cloud-provider#79

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 9, 2023
@bowei
Copy link
Member

bowei commented Mar 9, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2023
@bowei
Copy link
Member

bowei commented Mar 9, 2023

I think it's possible to delete /vendor now?

@spencerhance
Copy link
Contributor Author 

Checking go vet: FAIL
# k8s.io/legacy-cloud-providers/gce
vendor/k8s.io/legacy-cloud-providers/gce/gce.go:542:18: cannot use &gceRateLimiter{…} (value of type *gceRateLimiter) as cloud.RateLimiter value in struct literal: *gceRateLimiter does not implement cloud.RateLimiter (missing method Observe)

Hmm it looks like GoogleCloudPlatform/k8s-cloud-provider#77 is conflicting with k8s.io/legacy-cloud-providers/gce/gce.go

https://github.com/kubernetes/legacy-cloud-providers/blob/master/gce/support.go#L45

@spencerhance
Copy link
Contributor Author

kubernetes/kubernetes#116448 for the fix

@spencerhance
Copy link
Contributor Author

/hold

In summary we're blocked on updating k8s-cloud-provider until we are able to submit and import kubernetes/kubernetes#116448 unless we revert GoogleCloudPlatform/k8s-cloud-provider#77

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2023
@spencerhance spencerhance mentioned this pull request Mar 22, 2023
Merged
@spencerhance
Copy link
Contributor Author

New approach: #2033

@spencerhance spencerhance force-pushed the k8s-cloud-provider-1-21 branch from fb224fc to 8847df6 Compare March 23, 2023 21:31
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 23, 2023
@spencerhance spencerhance force-pushed the k8s-cloud-provider-1-21 branch from 8847df6 to 585b238 Compare March 23, 2023 21:33
@spencerhance spencerhance changed the title Bump k8s-cloud-provider to v1.21.0 Bump k8s-cloud-provider to v1.22.0 Mar 23, 2023
@spencerhance
Copy link
Contributor Author

spencerhance commented Mar 23, 2023 •
edited
Loading

Changed it to v1.22.0 instead of v1.21.0 so we can also pull in @gauravkghildiyal 's changes

@spencerhance
Copy link
Contributor Author

/assign @aojea

@spencerhance
Copy link
Contributor Author

/cc @gauravkghildiyal

@k8s-ci-robot
Copy link
Contributor

@spencerhance: GitHub didn't allow me to request PR reviews from the following users: gauravkghildiyal.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @gauravkghildiyal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gauravkghildiyal
Copy link
Member

gauravkghildiyal commented Mar 23, 2023 •
edited
Loading

Thanks a lot Spencer!

@spencerhance spencerhance force-pushed the k8s-cloud-provider-1-21 branch from 585b238 to ba5828e Compare March 23, 2023 22:13
@spencerhance
Copy link
Contributor Author

Whoops, missed a vendor/ file, updated now.

@spencerhance
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2023
@bowei
Copy link
Member

bowei commented Mar 23, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3bea50f into kubernetes:master Mar 23, 2023
@aojea
Copy link
Member

aojea commented Mar 24, 2023

sorry missed, it, thanks

@gauravkghildiyal gauravkghildiyal mentioned this pull request Mar 31, 2023
Closed
@spencerhance spencerhance deleted the k8s-cloud-provider-1-21 branch April 2, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@bowei bowei

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spencerhance @k8s-ci-robot @bowei @gauravkghildiyal @aojea