Create run-make-cmd.sh #2046
Create run-make-cmd.sh #2046
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/test pull-ingress-gce-e2e |
|
/assign @gauravkghildiyal |
|
@aojea: GitHub didn't allow me to assign the following users: gauravkghildiyal. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hack/run-make-cmd.sh
Outdated
|
|
||
| make build CONTAINER_BINARIES="${BINARY}" | ||
| make all-push VERBOSE="${VERBOSE}" CONTAINER_BINARIES="${BINARY}" REGISTRY="${REGISTRY}" ALL_ARCH="${ALL_ARCH}" | ||
| make push VERBOSE="${VERBOSE}" CONTAINER_BINARIES="${BINARY}" REGISTRY="${REGISTRY}" |
There was a problem hiding this comment.
I don't know this but would like you to confirm -- does "all-push" not include "push"? Or you have something else in mind because of which you want both?
There was a problem hiding this comment.
Sure.
make push - pushes images:
- gcr.io/k8s-ingress-image-push/ingress-gce-e2e-test-amd64
- gcr.io/k8s-ingress-image-push/ingress-gce-e2e-test-arm64
And make all-push, combines those images into one manifest and pushes an multiarch image:
- gcr.io/k8s-ingress-image-push/ingress-gce-e2e-test
@aojea JFYI 🤸♀️
There was a problem hiding this comment.
Oh it makes sense now. I didn't know this. Yes we should have both. Thanks!
code-elinka
force-pushed
the
run-make
branch
2 times, most recently
from
be3bd22 to
74ef968
Compare
|
Looks good to me now. Thanks @code-elinka |
|
/assign @aojea |
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: code-elinka, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
It is hard to run an image with multiple commands inside a python script (example: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml) because it will be presented not like:
but: