Run a ingress-gce script

[code-elinka]

It is tricky to run a list of commands inside
config yamls. To do that it's better to run
a script. The script builds & pushes the e2e-test
image on multiarch.

[code-elinka]

/assign @panslava
/assign @aojea
/assign @swetharepakula

[code-elinka]

/ok-to-test

[mmamczur]

looks ok, I don't have permission to approve though

[DamianSawicki]

It seems to me that you have forgotten to add the file hack/run-make-cmd.sh to the commit.

[code-elinka]

It seems to me that you have forgotten to add the file hack/run-make-cmd.sh to the commit.

It is a part of another commit: kubernetes/ingress-gce#2046

[DamianSawicki]

I see, thanks for the clarification! I was looking for this file in https://github.com/kubernetes/test-infra/tree/7750f9b325a0ababc84e560e143bc282f6780d9f/hack 😅

[panslava]

/lgtm

but I am not the owner of this repo

[code-elinka]

/assign @dims

[dims]

/assign @aojea

[aojea]

I don't think this is correct, ARCH should define the target arch, not the one the job is running

[code-elinka]

Do you know how to get a target ARCH in the script that test-infra runs?

[aojea]

Ok, then maybe I misunderstood it, why do you need the current arch for crosscompiling?

[code-elinka]

@aojea In the Makefile we see an ARCH = amd64. To override it we need to pass the desired architecture.
Otherwise the script will try to build ALL_ARCH on the same machine. It will fail or, even worse, it will build something on a wrong arch and push a new image that will be hard to debug 🤣

We could change Makefile itself and run the $(dpkg --print-architecture) command inside of it. I am not sure it makes the difference.

but I am also not sure if running --env=ARCH=$(dpkg --print-architecture) will have the same result as running export ARCH=$(dpkg --print-architecture) inside building container

[aojea]

ok, got it, but the infra doesn't have arm workers at this moment so we can omit that step by now, besides is more correct as you say

we can also migrate the job, this will result in something like

  kubernetes/ingress-gce:
  - name: ci-ingress-gce-image-push
    decorate: true
    labels:
      preset-service-account: "true"
      preset-k8s-ssh: "true"
      preset-dind-enabled: "true"
    spec:
      containers:
      - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230328-17e539c80f-master
        command:
        - runner.sh
        - hack/run-make-cmd.sh
        securityContext:
          privileged: true
        env:
        - name: ALL_ARCH
          value: "amd64 arm64"
        - name: BINARY
          value: "e2e-test"
    annotations:
      testgrid-dashboards: sig-network-ingress-gce-e2e
      testgrid-tab-name: ingress-gce-image-push
      testgrid-alert-email: kubernetes-sig-network-test-failures@googlegroups.com

[aojea]

/lgtm
/approve

Thanks 🤞

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-network/OWNERS [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@code-elinka: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml

In response to this:

It is tricky to run a list of commands inside
config yamls. To do that it's better to run
a script. The script builds & pushes the e2e-test
image on multiarch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DamianSawicki]

@code-elinka @aojea You guys should be sleeping now!

[aojea]

this is the OSS hour XD