Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build binaries for docker images in cloudbuild.yaml #2108

Merged
merged 1 commit into from
May 10, 2023
Merged

Build binaries for docker images in cloudbuild.yaml #2108

merged 1 commit into from
May 10, 2023

Conversation

code-elinka
Copy link
Contributor

If I run an image: gcr.io/k8s-ingress-image-push/ingress-gce-e2e-test
I see an error:

==============================================================================
E2E TEST

./run.sh: line 113: /e2e-test: No such file or directory

It means it doesn't have binaries that were supposed to be copied.
This change adds a line that builds those binaries (make all-build).

@k8s-ci-robot k8s-ci-robot requested review from aojea and kl52752 May 10, 2023 08:48
@code-elinka
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 10, 2023
@code-elinka
Copy link
Contributor Author

/assign @aojea

aojea
aojea reviewed May 10, 2023
View reviewed changes
cloudbuild.yaml Outdated
args:
- -c
- |
echo "build binaries"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about using two different steps, one for each command?
https://cloud.google.com/build/docs/build-config-file-schema#yaml_8

@aojea
Copy link
Member

aojea commented May 10, 2023

/hold

I don't have the same problem

 docker run gcr.io/k8s-ingress-image-push/ingress-gce-e2e-test:master

--- BEGIN ---
Warning: could not get Compute project name from the metadata server (attempt 1)
Warning: could not get Compute project name from the metadata server (attempt 2)
Warning: could not get Compute project name from the metadata server (attempt 3)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2023
@aojea
Copy link
Member

aojea commented May 10, 2023

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 10, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2023
@code-elinka
Copy link
Contributor Author

The actual problem is that binaries that are built are not multiarch but amd in multiarch wrapping https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-ingress-gce-push-image/1656111566392659968#1:build-log.txt%3A1360

@aojea PTAL

@aojea
Copy link
Member

aojea commented May 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08148e1 into kubernetes:master May 10, 2023
aojea
aojea reviewed May 10, 2023
View reviewed changes
cloudbuild.yaml
args:
- -c
- |
VERBOSE="${VERBOSE}" make all-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this failing now?
you don't need to add it here since is already in the env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@kl52752 kl52752 Awaiting requested review from kl52752

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@code-elinka @aojea @k8s-ci-robot