Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binaries for docker images in cloudbuild.yaml #2108

Merged
merged 1 commit into from
May 10, 2023
Merged

Build binaries for docker images in cloudbuild.yaml #2108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,35 @@ options:
machineType: E2_HIGHCPU_8
steps:
- name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20230206-8160eea68e
entrypoint: make
id: build-binaries
entrypoint: bash
env:
- DOCKER_CLI_EXPERIMENTAL=enabled
- REGISTRY="gcr.io/k8s-ingress-image-push"
- VERSION=$_PULL_BASE_REF
- VERBOSE=1
- HOME=/root
- USER=root
args: ['all-push','ALL_ARCH=amd64 arm64']
- DOCKER_CLI_EXPERIMENTAL=enabled
- VERSION=$_PULL_BASE_REF
- ALL_ARCH="amd64 arm64"
- VERBOSE=1
- HOME=/root
- USER=root
args:
- -c
- |
VERBOSE="${VERBOSE}" make all-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this failing now?
you don't need to add it here since is already in the env

- name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20230206-8160eea68e
id: push-images
waitFor: ["build-binaries"]
entrypoint: bash
env:
- DOCKER_CLI_EXPERIMENTAL=enabled
- REGISTRY="gcr.io/k8s-ingress-image-push"
- VERSION=$_PULL_BASE_REF
- ALL_ARCH="amd64 arm64"
- VERBOSE=1
- HOME=/root
- USER=root
args:
- -c
- |
make all-push ALL_ARCH="${ALL_ARCH}"
substitutions:
_GIT_TAG: "12345"
_PULL_BASE_REF: "main"