-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images: Remove NGINX v1.21. #12031
base: main
Are you sure you want to change the base?
Images: Remove NGINX v1.21. #12031
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/cherry-pick release-1.10 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.11 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d7a6b4b
to
91a813a
Compare
@@ -22,7 +22,7 @@ INIT_BUILDX=$(DIR)/../../hack/init-buildx.sh | |||
|
|||
# 0.0.0 shouldn't clobber any released builds | |||
SHORT_SHA ?=$(shell git rev-parse --short HEAD) | |||
TAG ?=v$(shell date +%Y%m%d)-$(SHORT_SHA) | |||
TAG ?=$(shell cat TAG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag is not on main anymore, maybe add a comment about that.
What this PR does / why we need it:
This PR removes the old NGINX v1.21 image. Controller versions using this image are already no longer supported. I therefore renamed the
images/nginx-1.25
directory toimages/nginx
. A change in thekubernetes/test-infra
repo is required before merging this PR./triage accepted
/kind cleanup
/priority backlog
/cc @strongjz @rikatz @cpanato @tao12345666333
/hold
Types of changes
Checklist: