-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress NGINX: Remove NGINX v1.21. #33548
Conversation
Skipping CI for Draft Pull Request. |
It's hard to read on mobile, but we can't delete images in the k8s.io registry. |
Oh, this is the job, not the registry ;)
|
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, cpanato, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@Gacko: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The PR title might suggest removing NGINX v1.21. Actually we are renaming
nginx-1.25
to justnginx
in the Ingress NGINX repository. As there already is a job config fornginx
, which was used for NGINX v1.21 before, we effectively just remove the NGINX v1.25 config and re-use the NGINX v1.21 config.Please consider also reviewing kubernetes/ingress-nginx#12031 when reviewing this PR as they need to get merged/unhold shortly after each other.