Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress NGINX: Remove NGINX v1.21. #33548

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Sep 29, 2024

The PR title might suggest removing NGINX v1.21. Actually we are renaming nginx-1.25 to just nginx in the Ingress NGINX repository. As there already is a job config for nginx, which was used for NGINX v1.21 before, we effectively just remove the NGINX v1.25 config and re-use the NGINX v1.21 config.

Please consider also reviewing kubernetes/ingress-nginx#12031 when reviewing this PR as they need to get merged/unhold shortly after each other.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 29, 2024
@Gacko Gacko marked this pull request as ready for review September 29, 2024 21:48
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 29, 2024
@Gacko
Copy link
Member Author

Gacko commented Sep 29, 2024

@strongjz
Copy link
Member

It's hard to read on mobile, but we can't delete images in the k8s.io registry.

@strongjz
Copy link
Member

Oh, this is the job, not the registry ;)

It's hard to read on mobile, but we can't delete images in the k8s.io registry.

@ameukam
Copy link
Member

ameukam commented Sep 30, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, cpanato, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko
Copy link
Member Author

Gacko commented Oct 1, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit e85e62a into kubernetes:master Oct 1, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Gacko: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-ingress-nginx.yaml using file config/jobs/image-pushing/k8s-staging-ingress-nginx.yaml

In response to this:

The PR title might suggest removing NGINX v1.21. Actually we are renaming nginx-1.25 to just nginx in the Ingress NGINX repository. As there already is a job config for nginx, which was used for NGINX v1.21 before, we effectively just remove the NGINX v1.25 config and re-use the NGINX v1.21 config.

Please consider also reviewing kubernetes/ingress-nginx#12031 when reviewing this PR as they need to get merged/unhold shortly after each other.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko Gacko deleted the jvutl branch October 1, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants