Add e2e test suite to detect memory leaks in lua #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #4236 +/- ##
=========================================
Coverage ? 57.85%
=========================================
Files ? 87
Lines ? 6544
Branches ? 0
=========================================
Hits ? 3786
Misses ? 2327
Partials ? 431Continue to review full report at Codecov.
|
aledbf
force-pushed
the
leaks
branch
2 times, most recently
from
7393886 to
b7d3bda
Compare
aledbf
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-ingress-nginx-test |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
aledbf
removed
the
do-not-merge/hold
ElvinEfendi
reviewed
Jun 28, 2019
| @@ -632,7 +631,6 @@ stream { | |||
| lua_shared_dict tcp_udp_configuration_data 5M; | |||
|
|
|||
| init_by_lua_block { | |||
| require("resty.core") | |||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FOCUS=DynamicCertificates E2E_CHECK_LEAKS=true make e2e-testWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: