-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test suite to detect memory leaks in lua #4236
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Copyright 2018 The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| if ! [ -z "$DEBUG" ]; then | ||
| set -x | ||
| fi | ||
|
|
||
| set -o errexit | ||
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| RED='\e[35m' | ||
| NC='\e[0m' | ||
| BGREEN='\e[32m' | ||
|
|
||
| declare -a mandatory | ||
| mandatory=( | ||
| E2E_NODES | ||
| SLOW_E2E_THRESHOLD | ||
| ) | ||
|
|
||
| missing=false | ||
| for var in "${mandatory[@]}"; do | ||
| if [[ -z "${!var:-}" ]]; then | ||
| echo -e "${RED}Environment variable $var must be set${NC}" | ||
| missing=true | ||
| fi | ||
| done | ||
|
|
||
| if [ "$missing" = true ]; then | ||
| exit 1 | ||
| fi | ||
|
|
||
| function cleanup { | ||
| kubectl delete pod e2e 2>/dev/null || true | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| E2E_CHECK_LEAKS=${E2E_CHECK_LEAKS:-} | ||
| FOCUS=${FOCUS:-.*} | ||
|
|
||
| export E2E_CHECK_LEAKS | ||
| export FOCUS | ||
|
|
||
| echo -e "${BGREEN}Granting permissions to ingress-nginx e2e service account...${NC}" | ||
| kubectl create serviceaccount ingress-nginx-e2e || true | ||
| kubectl create clusterrolebinding permissive-binding \ | ||
| --clusterrole=cluster-admin \ | ||
| --user=admin \ | ||
| --user=kubelet \ | ||
| --serviceaccount=default:ingress-nginx-e2e || true | ||
|
|
||
| until kubectl get secret | grep -q ^ingress-nginx-e2e-token; do \ | ||
| echo -e "waiting for api token"; \ | ||
| sleep 3; \ | ||
| done | ||
|
|
||
| kubectl run --rm \ | ||
| --attach \ | ||
| --restart=Never \ | ||
| --generator=run-pod/v1 \ | ||
| --env="E2E_NODES=${E2E_NODES}" \ | ||
| --env="FOCUS=${FOCUS}" \ | ||
| --env="E2E_CHECK_LEAKS=${E2E_CHECK_LEAKS}" \ | ||
| --env="SLOW_E2E_THRESHOLD=${SLOW_E2E_THRESHOLD}" \ | ||
| --overrides='{ "apiVersion": "v1", "spec":{"serviceAccountName": "ingress-nginx-e2e"}}' \ | ||
| e2e --image=nginx-ingress-controller:e2e |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| /* | ||
| Copyright 2019 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package leaks | ||
|
|
||
| import ( | ||
| "crypto/tls" | ||
| "fmt" | ||
| "net/http" | ||
| "strings" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "github.com/parnurzeal/gorequest" | ||
| pool "gopkg.in/go-playground/pool.v3" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "k8s.io/ingress-nginx/test/e2e/framework" | ||
| ) | ||
|
|
||
| var _ = framework.IngressNginxDescribe("DynamicCertificates", func() { | ||
| f := framework.NewDefaultFramework("lua-dynamic-certificates") | ||
|
|
||
| BeforeEach(func() { | ||
| f.NewEchoDeployment() | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| }) | ||
|
|
||
| framework.MemoryLeakIt("should not leak memory from ingress SSL certificates or configuration updates", func() { | ||
| hostCount := 1000 | ||
| iterations := 10 | ||
|
|
||
| By("Waiting a minute before starting the test") | ||
| time.Sleep(1 * time.Minute) | ||
|
|
||
| for iteration := 1; iteration <= iterations; iteration++ { | ||
| By(fmt.Sprintf("Running iteration %v", iteration)) | ||
|
|
||
| p := pool.NewLimited(200) | ||
|
|
||
| batch := p.Batch() | ||
|
|
||
| for index := 1; index <= hostCount; index++ { | ||
| host := fmt.Sprintf("hostname-%v", index) | ||
| batch.Queue(run(host, f)) | ||
| } | ||
|
|
||
| batch.QueueComplete() | ||
| batch.WaitAll() | ||
|
|
||
| p.Close() | ||
|
|
||
| By("waiting one minute before next iteration") | ||
| time.Sleep(1 * time.Minute) | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| func privisionIngress(hostname string, f *framework.Framework) { | ||
| ing := f.EnsureIngress(framework.NewSingleIngressWithTLS(hostname, "/", hostname, []string{hostname}, f.Namespace, "http-svc", 80, nil)) | ||
| _, err := framework.CreateIngressTLSSecret(f.KubeClientSet, | ||
| ing.Spec.TLS[0].Hosts, | ||
| ing.Spec.TLS[0].SecretName, | ||
| ing.Namespace) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| f.WaitForNginxServer(hostname, | ||
| func(server string) bool { | ||
| return strings.Contains(server, fmt.Sprintf("server_name %v", hostname)) && | ||
| strings.Contains(server, "listen 443") | ||
| }) | ||
| } | ||
|
|
||
| func checkIngress(hostname string, f *framework.Framework) { | ||
| req := gorequest.New() | ||
| resp, _, errs := req. | ||
| Get(f.GetURL(framework.HTTPS)). | ||
| TLSClientConfig(&tls.Config{ServerName: hostname, InsecureSkipVerify: true}). | ||
| Set("Host", hostname). | ||
| End() | ||
| Expect(errs).Should(BeEmpty()) | ||
| Expect(resp.StatusCode).Should(Equal(http.StatusOK)) | ||
|
|
||
| // check the returned secret is not the fake one | ||
| cert := resp.TLS.PeerCertificates[0] | ||
| Expect(cert.DNSNames[0]).Should(Equal(hostname)) | ||
| } | ||
|
|
||
| func deleteIngress(hostname string, f *framework.Framework) { | ||
| err := f.KubeClientSet.ExtensionsV1beta1().Ingresses(f.Namespace).Delete(hostname, &metav1.DeleteOptions{}) | ||
| Expect(err).NotTo(HaveOccurred(), "unexpected error deleting ingress") | ||
| } | ||
|
|
||
| func run(host string, f *framework.Framework) pool.WorkFunc { | ||
| return func(wu pool.WorkUnit) (interface{}, error) { | ||
| if wu.IsCancelled() { | ||
| return nil, nil | ||
| } | ||
|
|
||
| By(fmt.Sprintf("\tcreating ingress for host %v", host)) | ||
| privisionIngress(host, f) | ||
|
|
||
| time.Sleep(100 * time.Millisecond) | ||
|
|
||
| By(fmt.Sprintf("\tchecking ingress for host %v", host)) | ||
| checkIngress(host, f) | ||
|
|
||
| By(fmt.Sprintf("\tdestroying ingress for host %v", host)) | ||
| deleteIngress(host, f) | ||
|
|
||
| return true, nil | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍