-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration e2e installation to helm #5086
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5086 +/- ##
=========================================
+ Coverage 58.47% 58.68% +0.2%
=========================================
Files 88 88
Lines 6866 6850 -16
=========================================
+ Hits 4015 4020 +5
+ Misses 2410 2390 -20
+ Partials 441 440 -1
Continue to review full report at Codecov.
|
233c668
to
9adc90c
Compare
/retest |
/retest |
@aledbf: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@aledbf while the title says e2e migration, there are a lot of changes to other files in this PR, for example why did you change store.go or status update file? |
The change in the status is related to the tests to be able to merge flags in a different way. Also, the other changes in tests are related to the scope of RBAC rules. |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist:
/hold