Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration e2e installation to helm #5086

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Migration e2e installation to helm #5086

merged 1 commit into from
Feb 16, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 16, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2020
@codecov-io
Copy link

codecov-io commented Feb 16, 2020

Codecov Report

Merging #5086 into master will increase coverage by 0.2%.
The diff coverage is 56.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5086     +/-   ##
=========================================
+ Coverage   58.47%   58.68%   +0.2%     
=========================================
  Files          88       88             
  Lines        6866     6850     -16     
=========================================
+ Hits         4015     4020      +5     
+ Misses       2410     2390     -20     
+ Partials      441      440      -1
Impacted Files Coverage Δ
internal/ingress/controller/store/store.go 59.65% <56.66%> (+2.62%) ⬆️
internal/ingress/metric/collectors/process.go 90.62% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a8134...9adc90c. Read the comment docs.

@aledbf aledbf force-pushed the helm branch 2 times, most recently from 233c668 to 9adc90c Compare February 16, 2020 05:57
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2020
@aledbf
Copy link
Member Author

aledbf commented Feb 16, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Feb 16, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@aledbf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-test 4672403 link /test pull-ingress-nginx-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf aledbf merged commit 37c24b0 into kubernetes:master Feb 16, 2020
@aledbf aledbf deleted the helm branch February 16, 2020 15:00
@ElvinEfendi
Copy link
Member

@aledbf while the title says e2e migration, there are a lot of changes to other files in this PR, for example why did you change store.go or status update file?

@aledbf
Copy link
Member Author

aledbf commented Feb 19, 2020

The change in the status is related to the tests to be able to merge flags in a different way. Also, the other changes in tests are related to the scope of RBAC rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants