-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baremetal): Add kustomization.yaml #5965
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @haslersn! |
Hi @haslersn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c7e2aad
to
125928e
Compare
ok, that makes sense. That said, to accept the PR, please add the kustomization.yaml file to each directory in static/provider adding a comment that the file is provided only with the purpose to support kustomize bases. Something like # NOTE: kustomize is not supported. This file exists only to be able to reference it from bases
# https://kubectl.docs.kubernetes.io/pages/reference/kustomize.html#bases
# namespace: ingress-nginx
# bases:
# - github.com/kubernetes/ingress-nginx/deploy/static/provider/baremetal?ref=master
resources:
- deploy.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Tests should kick in after you push, I'll try to test this manually now while we await the additional changes
3a44373
to
fdf7b8f
Compare
I force-pushed my changes. However, AWS' |
fdf7b8f
to
948bdb5
Compare
948bdb5
to
7ddb734
Compare
/lgtm |
@haslersn thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, haslersn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could the non kustomize version still be kept around? The change broke my documentation. |
This change did not remove anything. What do you mean by "non kustomize version"? |
nvm sorry, I open a new ticket |
With this change, one can use kustomize to deploy ingress-nginx on bare-metal clusters. Example:
Usage: In the same folder run:
$ kubectl apply -k .
How Has This Been Tested?
Checklist: