Add configuration to disable external name service feature #7314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/assign @strongjz @ElvinEfendi |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
rikatz
added a commit
to rikatz/ingress-nginx
that referenced
this pull request
Jul 5, 2021
…s#7314) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
|
Also related to kubernetes/kubernetes#103675 |
rationalex
pushed a commit
to joomcode/ingress-nginx
that referenced
this pull request
May 18, 2022
…ature (kubernetes#7314) (kubernetes#7321) * Add configuration to disable external name service feature (kubernetes#7314) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix CI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com
What this PR does / why we need it:
This PR adds a new flag: --disable-svc-external-name
As a cluster admin, sometimes I don't want to allow my users to point Ingress to external address, but keep the traffic internally.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
E2E tests added
Checklist: