[Cherry Pick] - Add configuration to disable external name service feature (#7314) #7321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
kind/feature
go.sum
Outdated
| @@ -804,6 +811,27 @@ golang.org/x/sys v0.0.0-20200803210538-64077c9b5642/go.mod h1:h1NjWce9XRLGQEsW7w | |||
| golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | |||
| golang.org/x/sys v0.0.0-20201112073958-5cba982894dd h1:5CtCZbICpIOFdgO940moixOPjc0178IU44m4EjOO5IY= | |||
| golang.org/x/sys v0.0.0-20201112073958-5cba982894dd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
yeah, idiot me...
just tidyied the go.sum here again :D
…s#7314) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
rikatz
force-pushed
the
disable-external-v0x
branch
from
e5f55cf
to
3db4a47
Compare
k8s-ci-robot
added
the
lgtm
|
@rikatz need trigger the GitHub actions |
|
There's something strange happening here. It says there's a timeout waiting for e2e pod to run in GH actions, but the same branch runs correctly here in my machine with k8s v1.17. Will do some further investigation |
|
/lgtm |
strongjz
approved these changes
Jul 5, 2021
k8s-ci-robot
removed
the
lgtm
rikatz
force-pushed
the
disable-external-v0x
branch
3 times, most recently
from
020711f
to
95d0d9b
Compare
rikatz
force-pushed
the
disable-external-v0x
branch
from
95d0d9b
to
73a6c1f
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, strongjz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rationalex
pushed a commit
to joomcode/ingress-nginx
that referenced
this pull request
May 18, 2022
…ature (kubernetes#7314) (kubernetes#7321) * Add configuration to disable external name service feature (kubernetes#7314) Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix CI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com
Cherry-pick of #7314 to branch v0.X
/assign @tao12345666333 @strongjz
/cc @tao12345666333 @strongjz
/kind cleanup feature