Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secure-verify-ca-secret annotation #716

Merged
merged 1 commit into from
May 17, 2017
Merged

Add secure-verify-ca-secret annotation #716

merged 1 commit into from
May 17, 2017

Conversation

jcmoraisjr
Copy link
Contributor

Add ingress.kubernetes.io/secure-verify-ca-secret annotation and a new types.Backend.SecureCACert field without changing previous behaviour.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 47.064% when pulling 8b5a6e7 on jcmoraisjr:jm-secure-ca into 07647fd on kubernetes:master.

@aledbf aledbf self-assigned this May 17, 2017
@aledbf
Copy link
Member

aledbf commented May 17, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@aledbf
Copy link
Member

aledbf commented May 17, 2017

@jcmoraisjr thanks and sorry for the delay in merging this PR

@aledbf aledbf merged commit 3dc7717 into kubernetes:master May 17, 2017
@jcmoraisjr jcmoraisjr deleted the jm-secure-ca branch May 18, 2017 01:00
@andremarianiello
Copy link
Contributor

I don't see this annotation documented here https://github.com/kubernetes/ingress-nginx/blob/master/docs/user-guide/annotations.md#annotations. Is it fully supported?

@maxlaverse maxlaverse mentioned this pull request Mar 5, 2018
Merged
@ElvinEfendi ElvinEfendi mentioned this pull request Aug 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcmoraisjr @k8s-reviewable @coveralls @aledbf @andremarianiello @k8s-ci-robot