Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ebs latest tags #1519

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Remove ebs latest tags #1519

merged 1 commit into from
Jan 12, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jan 12, 2021

the promoter cannot move tags, see also #1515 and kubernetes-sigs/promo-tools#212

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra labels Jan 12, 2021
@wongma7 wongma7 changed the title Fix ebs latest tags Remove ebs latest tags Jan 12, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021

/approve
/lgtm
I'm not sure this is actually going to work as expected, but let's find out. FYI @kubernetes/release-engineering @listx

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9ea306a into kubernetes:master Jan 12, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021

@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-image-promo/1349103518060908544 ran successfully

However, the tags remain

$ gcloud container images list-tags k8s.gcr.io/provider-aws/aws-ebs-csi-driver
DIGEST        TAGS                                   TIMESTAMP
bd115c94bdf5                                         2021-01-06T19:03:27
0d1c74a65ac8                                         2021-01-06T19:02:58
6972d9cc2a56                                         2021-01-06T19:01:55
70e361c02449                                         2021-01-06T18:56:05
a8ed0a90b49c  latest,v0.8.0                          2020-12-09T15:56:26
f0a707418799  latest-amazonlinux,v0.8.0-amazonlinux  2020-12-09T15:56:04
3801d90c7cfb  v0.8.1                                 1969-12-31T19:00:00
89870880dc6c  v0.8.1-amazonlinux                     1969-12-31T19:00:00

@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021

How did we not catch this attempt to move tags in an earlier presubmit?

@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021

#1509 should not have been allowed to merge

@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021

Output from the presubmit that ran against that PR: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/k8s.io/1509/pull-k8sio-cip/1347300200883949568/build-log.txt

Dry run appears to have skipped but not failed

E0107 21:54:03.422619      13 inventory.go:1925] edge {{gcr.io/k8s-staging-provider-aws   %!s(bool=true)} {aws-ebs-csi-driver latest-amazonlinux} sha256:89870880dc6c09ae7141874c4234a3af9d871edc61e7302802bfbd095c4826f9 {asia.gcr.io/k8s-artifacts-prod/provider-aws k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  %!s(bool=false)} {aws-ebs-csi-driver latest-amazonlinux}}: tag 'latest-amazonlinux' in dest points to sha256:f0a70741879930df4c70ae855c5dfc106e83c9678d956f80e965f71a57ac89c1, not sha256:89870880dc6c09ae7141874c4234a3af9d871edc61e7302802bfbd095c4826f9 (as per the manifest), but tag moves are not supported; skipping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants