Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull-k8sio-cip should fail on manifest changes that mutate tags #1520

Closed
spiffxp opened this issue Jan 12, 2021 · 20 comments
Closed

pull-k8sio-cip should fail on manifest changes that mutate tags #1520

spiffxp opened this issue Jan 12, 2021 · 20 comments
Assignees
@justaugustus @listx
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone
v1.23

Comments

@spiffxp
Copy link
Member

spiffxp commented Jan 12, 2021 •
edited
Loading

#1509 should not have been allowed to merge

It did, and broke:

pull-k8sio-cip appeared to skip, but not fail, attempted tag moves in dry-run mode: (ref: #1519 (comment))

FYI @kubernetes/release-engineering
@spiffxp spiffxp added sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 12, 2021
@xmudrii
Copy link
Member

xmudrii commented Jan 13, 2021

Is this eventually relevant/related to kubernetes-sigs/promo-tools#277?

@listx
Copy link
Contributor

listx commented Jan 20, 2021

/cc

@spiffxp
Copy link
Member Author

spiffxp commented Jan 21, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 21, 2021
@spiffxp spiffxp added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 22, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Apr 15, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Apr 15, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

/remove-lifecycle stale
FYI @listx if @tylerferrara is looking for other stuff to do

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

/assign @listx
ref: kubernetes-sigs/promo-tools#375

@spiffxp spiffxp mentioned this issue Jul 30, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

We hit this again with #2052 (subsequently reverted via #2421)

@listx
Copy link
Contributor

listx commented Jul 30, 2021

I've begun work on this now.

@listx
Copy link
Contributor

listx commented Aug 5, 2021

kubernetes-sigs/promo-tools#385 has been merged, so this is fixed now. I just need to deploy it to the various Prow jobs that use the promoter.

@listx
Copy link
Contributor

listx commented Aug 5, 2021

Waiting on kubernetes/test-infra#23148 to get merged.

@listx
Copy link
Contributor

listx commented Aug 5, 2021

This should be fixed now, but just for good measure let me try to perform a tag move in a fake promotion PR.

@spiffxp
Copy link
Member Author

spiffxp commented Aug 6, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Aug 6, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 2, 2021

@listx have you verified this is fixed?

@listx
Copy link
Contributor

listx commented Sep 2, 2021

@listx have you verified this is fixed?

@justaugustus Have we deployed a new version of the promoter that includes the fix from kubernetes-sigs/promo-tools#385 ?

@justaugustus
Copy link
Member

justaugustus commented Sep 2, 2021 •
edited
Loading

@listx have you verified this is fixed?

@justaugustus Have we deployed a new version of the promoter that includes the fix from kubernetes-sigs/k8s-container-image-promoter#385 ?

@listx -- This is still dependent on getting tests passing on the default dry-run PR: kubernetes-sigs/promo-tools#285
If you can assist in debugging the test failures, we can try and push this along.

@spiffxp
Copy link
Member Author

spiffxp commented Sep 15, 2021

@justaugustus I see kubernetes-sigs/promo-tools#285 has merged, are we running a version of the promoter that includes this fix now?

@justaugustus justaugustus mentioned this issue Sep 15, 2021
Closed
@justaugustus
Copy link
Member

justaugustus commented Sep 16, 2021 •
edited
Loading

@justaugustus I see kubernetes-sigs/promo-tools#285 has merged, are we running a version of the promoter that includes this fix now?

We are indeed! It was rolled out as part of kubernetes/test-infra#23591 (and kubernetes/test-infra#23593).
Testing here: #2738

/assign

@justaugustus
Copy link
Member

From #2738 (comment):

Confirmed failure on https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2738/pull-k8sio-cip/1438291342051512320:

level=error msg="edge {{gcr.io/k8s-staging-artifact-promoter   true} {cip 20200222-v2.3.1-109-gb6af319} sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 {us.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {cip 20200222-v2.3.1-109-gb6af319}}: tag 20200222-v2.3.1-109-gb6af319: ERROR: tag move detected from sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 to sha256:1a36d74b30052783c986326f522e3b5688ea17c0cad851f9b1f265a67b67785b" 

<snip...>

level=error msg="edge {{gcr.io/k8s-staging-artifact-promoter   true} {cip 20200222-v2.3.1-109-gb6af319} sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 {eu.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {cip 20200222-v2.3.1-109-gb6af319}}: tag 20200222-v2.3.1-109-gb6af319: ERROR: tag move detected from sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 to sha256:5c9a73a90fdfd08adaf3d53ae863144922958911952dfa67cbf9a0d33dedde63"

Thanks for the fix, @listx!

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

From #2738 (comment):

Confirmed failure on https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2738/pull-k8sio-cip/1438291342051512320:

level=error msg="edge {{gcr.io/k8s-staging-artifact-promoter   true} {cip 20200222-v2.3.1-109-gb6af319} sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 {us.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {cip 20200222-v2.3.1-109-gb6af319}}: tag 20200222-v2.3.1-109-gb6af319: ERROR: tag move detected from sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 to sha256:1a36d74b30052783c986326f522e3b5688ea17c0cad851f9b1f265a67b67785b" 

<snip...>

level=error msg="edge {{gcr.io/k8s-staging-artifact-promoter   true} {cip 20200222-v2.3.1-109-gb6af319} sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 {eu.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {cip 20200222-v2.3.1-109-gb6af319}}: tag 20200222-v2.3.1-109-gb6af319: ERROR: tag move detected from sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 to sha256:5c9a73a90fdfd08adaf3d53ae863144922958911952dfa67cbf9a0d33dedde63"

Thanks for the fix, @listx!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@listx listx mentioned this issue Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justaugustus justaugustus

@listx listx

Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
v1.23
Development

No branches or pull requests
6 participants
@spiffxp @justaugustus @listx @xmudrii @k8s-ci-robot @fejta-bot