Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "k8s-staging-csi-secrets-store: retag v0.0.22 to include #545" #2421

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Revert "k8s-staging-csi-secrets-store: retag v0.0.22 to include #545" #2421

merged 1 commit into from
Jul 30, 2021

Conversation

listx
Copy link
Contributor

@listx listx commented Jul 29, 2021

This reverts commit ebd4d3a.

Commit ebd4d3a attempted to retag a
production image, which is not allowed.

Revert "k8s-staging-csi-secrets-store: retag v0.0.22 to include kuber…
26e1c37 
…netes#545"

This reverts commit ebd4d3a.

Commit ebd4d3a attempted to retag a
production image, which is not allowed.
@listx
Copy link
Contributor Author

listx commented Jul 29, 2021

/cc @tam7t

@listx
Copy link
Contributor Author

listx commented Jul 29, 2021

/cc @aramase

@tam7t
Copy link
Contributor

tam7t commented Jul 29, 2021

This change in tags was done before we published the release and was necessary to fix an issue in the release, https://github.com/kubernetes-sigs/secrets-store-csi-driver/releases/tag/v0.0.22

TBH i think reverting would cause more harm than good as it would introduce a bug to clusters that are currently using v0.0.22 images

@aramase
Copy link
Member

aramase commented Jul 29, 2021

I agree with @tam7t

@listx Did the retag not work when the PR for retag was merged?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot requested review from aramase and ritazh July 29, 2021 20:47
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2021
@k8s-ci-robot k8s-ci-robot requested a review from tam7t July 29, 2021 20:47
@listx
Copy link
Contributor Author

listx commented Jul 29, 2021

I agree with @tam7t

@listx Did the retag not work when the PR for retag was merged?

Correct, the retag did not work because retagging is not supposed to work. So if you pull us.gcr.io/k8s-artifacts-prod/csi-secrets-store/driver:v0.0.22 right now it will pull us.gcr.io/k8s-artifacts-prod/csi-secrets-store/driver@sha256:1db2d1879a4ef656e3037a1d32be6bdb08cb10ea5800b6cca393361d6ac0330c (the old digest).

In other words, merging this PR will have no effect on production. Instead it is merely cleanup of unrealized config changes.

@spiffxp
Copy link
Member

spiffxp commented Jul 30, 2021

This is not the first time we've merged something that broke things. Should have been caught by presubmits. I'll find the open issue...

spiffxp
spiffxp approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: listx, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit c3c9a44 into kubernetes:main Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 30, 2021
@listx
Copy link
Contributor Author

listx commented Jul 30, 2021

This is not the first time we've merged something that broke things. Should have been caught by presubmits. I'll find the open issue...

I created kubernetes-sigs/promo-tools#375

@spiffxp
Copy link
Member

spiffxp commented Jul 30, 2021

Found it: #1520

Assigned to you and linked to the CIP issue

@spiffxp spiffxp mentioned this pull request Jul 30, 2021
Closed
@aramase
Copy link
Member

aramase commented Jul 30, 2021

In other words, merging this PR will have no effect on production. Instead it is merely cleanup of unrealized config changes.

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@aramase aramase Awaiting requested review from aramase

@ritazh ritazh Awaiting requested review from ritazh

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@listx @tam7t @aramase @spiffxp @k8s-ci-robot