-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: Add sbom.[k8s, kubernetes].io to certificate SANs #2458
Conversation
This commit adds the sbom.k8s.io and sbom.kubernetes.io hostnames to the prod and canary certificates SANs. These hostnames were recently added to the DNS and nginx configuration. Follow-up to: kubernetes#2447 Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manually deployed the certificates : ameukam@cloudshell:~/k8s.io/apps/k8s-io (kubernetes-public)$ kubectl apply -f certificate-canary.yaml
certificate.cert-manager.io/k8s-io-selfsigned configured ameukam@cloudshell:~/k8s.io/apps/k8s-io (kubernetes-public)$ kubectl apply -f certificate-prod.yaml
managedcertificate.networking.gke.io/k8s-io-prod created |
The certificate was requested in the wrong namespace. Deployed to kubectl apply -f certificate-prod.yaml -n k8s-io-prod Deleted the wrong one: kubectl -n default delete ManagedCertificate k8s-io-prod |
Thanks @ameukam I can PR the namespace into the YAML, would that be helpful? |
Very hepful. Planned to do that at the end of my workday. |
Done :) #2462 |
This commit adds the sbom.k8s.io and sbom.kubernetes.io hostnames to the prod and canary
certificate SANs. These hostnames were recently added to the DNS and nginx configuration.
Follow-up to: #2447
Part of: kubernetes/release#1837
/assign @ameukam
Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net