Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Bill of Materials #1837

Closed
19 tasks done
puerco opened this issue Jan 11, 2021 · 14 comments
Closed
19 tasks done

[Umbrella] Bill of Materials #1837

puerco opened this issue Jan 11, 2021 · 14 comments
Assignees
Labels
area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@puerco
Copy link
Member

puerco commented Jan 11, 2021

We intend to ensure the quality and integrity of the artifacts produced on each release cut by adding a Bill of Materials (BOM). The BOM will be published in SPDX and will include integrity and licensing information for the artifacts we produce. Work on this area will lead to close other outstanding issues (linked here).

Following our road-mapping session, this umbrella issue will track the development to create the BOM.

Make krel aware of binary artifacts expected from the release process:

Note: These items are postponed as we delayed the supported platforms effort to 1.23+

Verify/process binary artifacts as the release process advances from stage to stage

Write SPDX manifest(s). Output should include data about:

Publish the SPDX manifests with the other release artifacts:

Make our tools available community-wide

/cc @hasheddan @xmudrii @markyjackson-taulia

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jan 11, 2021
@nishakm
Copy link

nishakm commented Jan 12, 2021

cc @rnjudge and @kestewart for Tern

@tsteenbe
Copy link

@puerco If you need a tool to generate SPDX for Go and other languages, have a look at OSS Review Toolkit. I am both ORT and SPDX maintainer, happy to answer any questions you may have.

@puerco
Copy link
Member Author

puerco commented Jan 12, 2021

Thank you @tsteenbe I certainly will take a look at it :)

@LappleApple
Copy link

/area release-eng

@justaugustus
Copy link
Member

justaugustus commented Feb 10, 2021

Connecting some threads based on an OSS supply chain convo I had earlier in the week with folks across VMware, Red Hat, and Google (@ncdc, @dlorenc, @wattsteve, @lukehinds, @kimsterv, @jonjohnsonjr to name a few):

@saschagrunert @hasheddan @puerco -- Let's please leverage Rekor here as we build this out.

Of course, there's more to consider and supply chain concerns will be core to everything we do in RelEng, but the bill of materials is a great starting point.

cc: @kubernetes/sig-security-leads

Project Rekor xref: sigstore/rekor#156, sigstore/rekor#144

@justaugustus justaugustus added this to the v1.21 milestone Feb 10, 2021
@justaugustus justaugustus added area/release-eng/security Issues or PRs related to release engineering security kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 10, 2021
@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Feb 10, 2021
@lukehinds
Copy link

Rekor could in particular be beneficial for 'Publish the SPDX manifests with the other release artifacts' - this would provide two key benefits off the top of my head.

  1. immutability, making the BOMs tamper resistant.
  2. Public and assured transparency, e.g. more eyes to monitor the BOMs for anything untoward

I will read up on SPDX (tagging @bobcallaway for types expertise). Do you know if there will be some sort of signature at BOM generation time?

@puerco
Copy link
Member Author

puerco commented Feb 27, 2021

@lukehinds the first iteration of the SPDX BOM will not be signed as we have yet to set a key management mechanism before we start signing the manifests and other release artifacts. We hope to have it resolved soon(ish) as this is the main issue blocking us from generating and hosting debs and rpms in community infra.

@justaugustus
Copy link
Member

Noting this issue in cncf/foundation about short-form copyright headers w/ SPDX identifiers: cncf/foundation#143

puerco added a commit to puerco/release that referenced this issue Aug 3, 2021
This commit updates the Namespaces in the SPDX documents of
the SBOM to the final hostname: sbom.k8s.io

This is needed to make them valid as this is the reference
that links both SBOMs.

Part of: kubernetes#1837

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
puerco added a commit to puerco/release that referenced this issue Aug 19, 2021
This commit updates the Namespaces in the SPDX documents of
the SBOM to the final hostname: sbom.k8s.io

This is needed to make them valid as this is the reference
that links both SBOMs.

Part of: kubernetes#1837

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@saschagrunert
Copy link
Member

@puerco is this one done?

@saschagrunert
Copy link
Member

@puerco can we close this one as done?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@reylejano
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@puerco
Copy link
Member Author

puerco commented Jan 10, 2022

The SBOM project is done. We are now producing SBOMs with all k8s releases:

https://sbom.k8s.io/v1.23.0/release
https://sbom.k8s.io/v1.23.0/source

And we have spun off the took into its own repository: https://sigs.k8s.io/bom

Thanks for all your help and support, everybody! 🥳

/close

@k8s-ci-robot
Copy link
Contributor

@puerco: Closing this issue.

In response to this:

The SBOM project is done. We are now producing SBOMs with all k8s releases:

https://sbom.k8s.io/v1.23.0/release
https://sbom.k8s.io/v1.23.0/source

And we have spun off the took into its own repository: https://sigs.k8s.io/bom

Thanks for all your help and support, everybody! 🥳

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

10 participants