Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][DO NOT MERGE] Attempt to mutate already promoted tags #2738

Closed
wants to merge 1 commit into from
Closed

[WIP][DO NOT MERGE] Attempt to mutate already promoted tags #2738

wants to merge 1 commit into from

Conversation

justaugustus
Copy link
Member

...which SHOULD fail in presubmit.

Tests #1520
cc: @spiffxp (#1520 (comment)) @kubernetes/release-engineering

Signed-off-by: Stephen Augustus foo@auggie.dev

/hold

@justaugustus
[DO NOT MERGE] Attempt to mutate already promoted tags
161ec71 
...which **_SHOULD_** fail in presubmit.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-k8sio-cip 161ec71 link /test pull-k8sio-cip

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus justaugustus mentioned this pull request Sep 16, 2021
Closed
@justaugustus
Copy link
Member Author

Confirmed failure on https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2738/pull-k8sio-cip/1438291342051512320:

level=error msg="edge {{gcr.io/k8s-staging-artifact-promoter   true} {cip 20200222-v2.3.1-109-gb6af319} sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 {us.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {cip 20200222-v2.3.1-109-gb6af319}}: tag 20200222-v2.3.1-109-gb6af319: ERROR: tag move detected from sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 to sha256:1a36d74b30052783c986326f522e3b5688ea17c0cad851f9b1f265a67b67785b" 

<snip...>

level=error msg="edge {{gcr.io/k8s-staging-artifact-promoter   true} {cip 20200222-v2.3.1-109-gb6af319} sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 {eu.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {cip 20200222-v2.3.1-109-gb6af319}}: tag 20200222-v2.3.1-109-gb6af319: ERROR: tag move detected from sha256:1e6fa1a97fcd3a3142aa51516552c16cfbeba58d16bd202365484d35def433d6 to sha256:5c9a73a90fdfd08adaf3d53ae863144922958911952dfa67cbf9a0d33dedde63"

@justaugustus
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justaugustus @k8s-ci-robot