-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image promotion for kube-state-metrics v2.8.2 #4956
Image promotion for kube-state-metrics v2.8.2 #4956
Conversation
|
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
f5bf24f
to
5acb759
Compare
/hold Please lgtm/approve and let me cancel the hold on release day tomorrow. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey, you'll have to move this to registry.k8s.io/, sorry we're working on kubernetes/enhancements#3720 ref #4934 kubernetes/test-infra#29069 [forcing bot to process this, will reopen immediately] |
@BenTheElder: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@BenTheElder: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mrueg: Adding label: Reasons for blocking this PR:[k8s.gcr.io Image registry is frozen from April 2023. Please update the manifests in registry.k8s.io folder instead] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@BenTheElder since we would like to release tomorrow and the k8s.gcr.io freeze date is in 2 weeks, can we still process this one? |
#4934 just moved the configurations from If you update this PR to move identically you're good to go. But no files will be under k8s.gcr.io/ anymore That's just a rename to clarify things as part of the freeze, it's not strictly coupled to which registries the images wind up in. However: Please DO NOT tell people to pull your new image from k8s.gcr.io even if it winds up available there. k8s.gcr.io is deprecated and https://registry.k8s.io is the way forward for the project. We have a tracking issue to ensure all subproject references get updated independent of the freeze on GCR #4738 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more specifically: rebase or recreate this diff against registry.k8s.io/images/k8s-staging-kube-state-metrics/images.yaml
and the bot will lift the do-not-merged/blocked-paths
label.
the same tooling will copy the images to production, and they'll be at pullable at registry.k8s.io/$image:$tag
(as they also would have been before moving the source directory here)
@rexagod @dgrisonnet @fpetkovski