Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image promotion for kube-state-metrics v2.8.2 #4956

Closed

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Mar 16, 2023

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 16, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mrueg / name: Manuel Rüger (5acb759)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2023
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@mrueg mrueg force-pushed the kube-state-metrics-v2.8.2-image-promotion branch from f5bf24f to 5acb759 Compare March 16, 2023 11:21
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 16, 2023
@mrueg
Copy link
Member Author

mrueg commented Mar 16, 2023

/hold

Please lgtm/approve and let me cancel the hold on release day tomorrow.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2023
@dgrisonnet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

Hey, you'll have to move this to registry.k8s.io/, sorry we're working on kubernetes/enhancements#3720 ref #4934 kubernetes/test-infra#29069

[forcing bot to process this, will reopen immediately]
/close

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Closed this PR.

In response to this:

Hey, you'll have to move this to registry.k8s.io/, sorry we're working on kubernetes/enhancements#3720 ref #4934 kubernetes/test-infra#29069

[forcing bot to process this, will reopen immediately]
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

@mrueg: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[k8s.gcr.io Image registry is frozen from April 2023. Please update the manifests in registry.k8s.io folder instead]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrueg
Copy link
Member Author

mrueg commented Mar 16, 2023

@BenTheElder since we would like to release tomorrow and the k8s.gcr.io freeze date is in 2 weeks, can we still process this one?

@BenTheElder
Copy link
Member

BenTheElder commented Mar 16, 2023

@BenTheElder since we would like to release tomorrow and the k8s.gcr.io freeze date is in 2 weeks, can we still process this one?

#4934 just moved the configurations from k8s.gcr.io/ to registry.k8s.io/ folder

If you update this PR to move identically you're good to go. But no files will be under k8s.gcr.io/ anymore

That's just a rename to clarify things as part of the freeze, it's not strictly coupled to which registries the images wind up in.

However: Please DO NOT tell people to pull your new image from k8s.gcr.io even if it winds up available there. k8s.gcr.io is deprecated and https://registry.k8s.io is the way forward for the project. We have a tracking issue to ensure all subproject references get updated independent of the freeze on GCR #4738

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more specifically: rebase or recreate this diff against registry.k8s.io/images/k8s-staging-kube-state-metrics/images.yaml and the bot will lift the do-not-merged/blocked-paths label.

the same tooling will copy the images to production, and they'll be at pullable at registry.k8s.io/$image:$tag (as they also would have been before moving the source directory here)

@mrueg mrueg closed this Mar 17, 2023
@mrueg mrueg deleted the kube-state-metrics-v2.8.2-image-promotion branch March 17, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants