Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing arguments #54

Closed
adrianlzt opened this issue Apr 4, 2019 · 5 comments
Closed

Confusing arguments #54

adrianlzt opened this issue Apr 4, 2019 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@adrianlzt
Copy link

/kind bug

What steps did you take and what happened:
It is kinda difficult to configure logging, as arguments don't work as expected.

Doc is outdated and still show glog:
https://godoc.org/k8s.io/klog

-logtostderr=false

But in code is defaulted to true:

flagset.BoolVar(&logging.toStderr, "logtostderr", true, "log to standard error instead of files")

Examples of weird behaviours.

No initialization shows >=error:

klog.Info("info")
klog.Error("error")

But if klog is initializated, it shows info and error (because flag logtostderr is set to true):

klog.InitFlags(nil)
flag.Parse()
klog.Info("info")
klog.Error("error")

Also weird because default value for stderrthreshold is ERROR and the doc says:

Log events at or above this severity are logged to standard error as well as to files

Then I switch off logging to stderr:

klog.InitFlags(nil)
flag.Set("logtostderr", "false")
flag.Parse()
klog.Info("info")
klog.Error("error")

And now it keeps logging to stderr but just error level.

What did you expect to happen:
Updated doc and a understandable behaviour.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 4, 2019
@DirectXMan12
Copy link

There's two issues at play here:

  1. The flag initialization issue (that's pretty sub-optimal)
  2. The confusing nature of glog/klog flags and stderror -- that's a bit harder to fix due to backwards compat constraints, but we want to do it. You're not the first person to be confused/frustrated by that.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants