-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use info in default stderrThreshold #42
Conversation
3a8c55a
to
b3fc759
Compare
/approve let's wait to see if anyone objects for a little bit |
Signed-off-by: Vince Prignano <vincepri@vmware.com>
b3fc759
to
9e8a655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seems like the right thing to do after the previous PR.
@dims Should we merge this? I'm eager to update some repos and cleanup init(s). |
go for it @vincepri /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR is a follow-up to #39, it sets the default threshold for stderr logging to
INFO
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: