Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default logtostderr to true #39

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jan 29, 2019

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:
This PR changes the default logtostderr to "true", more details and discussion can be found in #38.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #38

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

The `logtostderr` flag now defaults to true.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2019
@DirectXMan12
Copy link

Needs a release note.

@DirectXMan12
Copy link

seems reasonable to me though (as mentioned in the corresponding issue).

holding to make sure others get a chance to weigh in, but given that k8s.io/kubernetes does this already, I don't see much harm in changing this.

@dims
Copy link
Member

dims commented Jan 30, 2019

/approve

leaving the lgtm for @DirectXMan12

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@DirectXMan12
Copy link

well, that's two people.

I'll LGTM tomorrow or whenever we get a release note, whichever is later.

@vincepri
Copy link
Member Author

@DirectXMan12 Added the release note :)

@DirectXMan12
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, DirectXMan12, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit efc166b into kubernetes:master Jan 31, 2019
@vincepri vincepri deleted the logtostderr-true branch January 31, 2019 19:44
mtaufen added a commit to mtaufen/klog that referenced this pull request Mar 4, 2019
@mtaufen mtaufen mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make (also)logtostderr default to true
4 participants