-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default logtostderr to true #39
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
Needs a release note. |
seems reasonable to me though (as mentioned in the corresponding issue). holding to make sure others get a chance to weigh in, but given that k8s.io/kubernetes does this already, I don't see much harm in changing this. |
/approve leaving the lgtm for @DirectXMan12 |
well, that's two people. I'll LGTM tomorrow or whenever we get a release note, whichever is later. |
@DirectXMan12 Added the release note :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, DirectXMan12, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR changes the default
logtostderr
to "true", more details and discussion can be found in #38.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #38
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: