Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaleway: use kops controller for bootstrap #15474

Merged
merged 5 commits into from
Jun 14, 2023
Merged

scaleway: use kops controller for bootstrap #15474

merged 5 commits into from
Jun 14, 2023

Conversation

Mia-Cross
Copy link
Contributor

This PR adds the possibility to use the kops-controller to bootstrap the nodes so there is no need to pass the credentials to the nodes.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Mia-Cross. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/provider/scaleway Issues or PRs related to Scaleway provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2023
@Mia-Cross Mia-Cross mentioned this pull request Jun 6, 2023
Closed
@hakman
Copy link
Member

hakman commented Jun 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2023
@Mia-Cross Mia-Cross force-pushed the scw_use_kops_controller_for_bootstrap branch from 12109ea to 153b82e Compare June 9, 2023 12:49
@Mia-Cross Mia-Cross marked this pull request as ready for review June 9, 2023 12:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zetaab June 9, 2023 12:49
hakman
hakman reviewed Jun 11, 2023
View reviewed changes
pkg/model/bootstrapscript.go Outdated
Comment on lines 142 to 144
if cluster.Spec.GetCloudProvider() == kops.CloudProviderScaleway && cluster.UsesLegacyGossip() {
passEnvs = true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only way I managed to have gossip clusters still working. Should we deprecate them right away and only support NoneDNS clusters ?

Copy link
Member

@hakman hakman Jun 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a good idea. By deprecate, you mean remove support in Scaleway?
Also, please take a look at #15493. It may be interesting for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is what I meant. Thanks for the link to the PR, I made a few changes according to it and gossip clusters work fine without this fix now 👍

@Mia-Cross Mia-Cross force-pushed the scw_use_kops_controller_for_bootstrap branch from 567a59d to 7232978 Compare June 14, 2023 13:12
@Mia-Cross Mia-Cross force-pushed the scw_use_kops_controller_for_bootstrap branch from 7232978 to 39ed846 Compare June 14, 2023 13:15
@Mia-Cross Mia-Cross force-pushed the scw_use_kops_controller_for_bootstrap branch from 609b9a1 to b9807d4 Compare June 14, 2023 13:48
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0762730 into kubernetes:master Jun 14, 2023
@Mia-Cross Mia-Cross deleted the scw_use_kops_controller_for_bootstrap branch June 14, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/kops-controller area/nodeup area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mia-Cross @k8s-ci-robot @hakman