-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kops-controller on hetzner, even with gossip #15493
Use kops-controller on hetzner, even with gossip #15493
Conversation
This is a more secure configuration.
@@ -60,7 +60,7 @@ func (b *LoadBalancerModelBuilder) Build(c *fi.CloudupModelBuilderContext) error | |||
}, | |||
} | |||
|
|||
if b.Cluster.UsesNoneDNS() { | |||
if b.Cluster.UsesNoneDNS() || b.UseKopsControllerForNodeBootstrap() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably could just do b.UseKopsControllerForNodeBootstrap()
at this point, but this seems like the more obvious change.
@@ -1419,44 +1419,64 @@ func (n *nodeUpConfigBuilder) BuildConfig(ig *kops.InstanceGroup, apiserverAddit | |||
} | |||
|
|||
// Set API server address to an IP from the cluster network CIDR | |||
var controlPlaneIPs []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bigger change, but is really saying "also use the fixed IP on hetzner"
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ller Use kops-controller on hetzner, even with gossip
This is a more secure configuration.