Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop skipping some cilium tests on newer k8s versions #15739

Closed
wants to merge 1 commit into from
Closed

Stop skipping some cilium tests on newer k8s versions #15739

wants to merge 1 commit into from

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Aug 4, 2023

It would be most accurate to skip based on kops version but we dont have access to that, so keying off of the k8s version is better than always skipping these tests

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rifelpet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet
Copy link
Member Author

rifelpet commented Aug 4, 2023

/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-cilium-etcd
/test pull-kops-e2e-cni-cilium-eni

@rifelpet
Copy link
Member Author

rifelpet commented Aug 5, 2023

These are the only two cilium jobs that use CI builds of k8s (1.28)

/test pull-kops-e2e-aws-cloud-controller-manager
/test pull-kops-e2e-k8s-gce-ci

@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-ci ef63b1f link true /test pull-kops-e2e-k8s-gce-ci
pull-kops-e2e-aws-cloud-controller-manager ef63b1f link true /test pull-kops-e2e-aws-cloud-controller-manager

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rifelpet
Stop skipping some cilium tests on newer k8s versions
bdb11d0 
It would be most accurate to skip based on kops version but we dont have access to that, so keying off of the k8s version is better than always skipping these tests
@rifelpet
Copy link
Member Author

superseded by #15753

@rifelpet rifelpet closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rifelpet @k8s-ci-robot