Trim e2e skip regexes for Cilium

[johngmyers]

Closes #15448

[johngmyers]

/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-cilium-etcd
/test pull-kops-e2e-cni-cilium-eni

[rifelpet]

The kops master branch is used to build kubetest2-kops for all e2e jobs including upgrade tests that upgrade to older kops versions that still use cilium 1.12. This change will stop skipping those tests for cilium 1.12 clusters which will cause failures.

https://github.com/kubernetes/test-infra/blob/17464456700f8d6158e5957e81b2472d6eb0e02a/config/jobs/kubernetes/kops/kops-periodics-upgrades.yaml#L17-L22

Maybe we could update build_jobs.py to clone the release branch for upgrade tests that upgrade to non-latest kops versions?

[johngmyers]

/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-cilium-etcd
/test pull-kops-e2e-cni-cilium-eni

[hakman]

K8s 1.28 will be released a week from now. I think what @rifelpet was doing with checking K8s version instead of kOps version was pretty good. We already do checks against k8sVersion.Minor.

[rifelpet]

nit: This will evaluate to false for any future 1.28 pre-release builds

[rifelpet]

And we can't inspect the Cluster manifest because spec.networking.cilium.version isn't guaranteed to be set. I suppose one alternative would be to inspect the daemonset itself with the kubectl binary that the tester downloads:

kops/tests/e2e/pkg/tester/kubectl.go

Lines 132 to 134 in 7e06e4c

	func KubectlPath() string {
	return artifacts.RunDir() + "/kubectl"
	}

[johngmyers]

Evaluating false for future 1.28 pre release builds is desired behavior

[johngmyers]

Checking k8s version has the undesirable behavior of skipping those tests on kops 1.28+ branch kops and <1.28 k8s

[hakman]

Checking k8s version has the undesirable behavior of skipping those tests on kops 1.28+ branch kops and <1.28 k8s

In my opinion, that is irrelevant. We aim for most maintainable code here, not for exact skip list.

[johngmyers]

Being able to remove the extra skips earlier leads to more maintainable code.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment