Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Calico to v3.27.0 #16192

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Update Calico to v3.27.0 #16192

merged 3 commits into from
Dec 27, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 27, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 27, 2023
@hakman
Copy link
Member Author

hakman commented Dec 27, 2023

/test pull-kops-e2e-cni-calico

hakman
hakman commented Dec 27, 2023
View reviewed changes
tests/e2e/kubetest2-kops/deployer/up.go
Comment on lines +297 to +299
if d.ValidationInterval > 10*time.Second {
args = append(args, "--interval", d.ValidationInterval.String())
}
Copy link
Member Author

@hakman hakman Dec 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For compatibility with older kOps versions that don't support this new flag, like pull-kops-e2e-aws-upgrade-k127-ko127-to-klatest-kolatest-many-addons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid ^^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed it today :(

@hakman
Copy link
Member Author

hakman commented Dec 27, 2023

/test pull-kops-e2e-cni-calico

upodroid
upodroid approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2023
@hakman
Copy link
Member Author

hakman commented Dec 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 711f28b into kubernetes:master Dec 27, 2023
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 27, 2023
@cmotta2016 cmotta2016 mentioned this pull request Mar 25, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
@zied-jt zied-jt mentioned this pull request May 24, 2024
Closed
@rifelpet rifelpet mentioned this pull request Jun 13, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 13, 2024
@k8s-ci-robot
Merge pull request #16613 from rifelpet/automated-cherry-pick-of-#16192-
ea7dc86 
#16363-origin-release-1.28

Automated cherry pick of #16192: Update Calico to v3.27.0
#16363: Update Calico to v3.27.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @upodroid