Remove incorrect zero value check #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check never returned true prior to go1.16, because using DeepEqual on reflect.Value return values checks their internal fields, and reflect.Zero included a unique unsafe pointer. In go1.16, reflect.Zero started returning shared zero values, and this check started returning true. However, requiring nullable on zero values is not correct. A zero value string "" should be valid even if the schema does not allow the field to be null.
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
lgtm
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Mar 4, 2021
Merged
|
reasoning looks sound to me. |
xiaods
added a commit
to xiaods/k8e
that referenced
this pull request
Oct 14, 2021
Remove incorrect zero value check kubernetes/kube-openapi#230 spec.bpfLogLevel in body must be of type string: "null" only go1.15 can handle it. Signed-off-by: Deshi Xiao <xiaods@gmail.com>
LukeShu
pushed a commit
to emissary-ingress/emissary
that referenced
this pull request
Jan 20, 2022
This turned out to be an upstream bug in k8s.io/kube-openapi. Upgrading that package fixes the bug. kubernetes/kube-openapi#230 Signed-off-by: Flynn <flynn@datawire.io> Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
kflynn
pushed a commit
to emissary-ingress/emissary
that referenced
this pull request
Jan 20, 2022
This turned out to be an upstream bug in k8s.io/kube-openapi. Upgrading that package fixes the bug. kubernetes/kube-openapi#230 Signed-off-by: Flynn <flynn@datawire.io> Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
kflynn
pushed a commit
to emissary-ingress/emissary
that referenced
this pull request
Jan 20, 2022
This turned out to be an upstream bug in k8s.io/kube-openapi. Upgrading that package fixes the bug. kubernetes/kube-openapi#230 Signed-off-by: Flynn <flynn@datawire.io> Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
kflynn
pushed a commit
to emissary-ingress/emissary
that referenced
this pull request
Jan 20, 2022
This turned out to be an upstream bug in k8s.io/kube-openapi. Upgrading that package fixes the bug. kubernetes/kube-openapi#230 Signed-off-by: Flynn <flynn@datawire.io> Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
kflynn
pushed a commit
to emissary-ingress/emissary
that referenced
this pull request
Jan 21, 2022
This turned out to be an upstream bug in k8s.io/kube-openapi. Upgrading that package fixes the bug. kubernetes/kube-openapi#230 Signed-off-by: Flynn <flynn@datawire.io> Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
kflynn
pushed a commit
to emissary-ingress/emissary
that referenced
this pull request
Jan 21, 2022
This turned out to be an upstream bug in k8s.io/kube-openapi. Upgrading that package fixes the bug. kubernetes/kube-openapi#230 Signed-off-by: Flynn <flynn@datawire.io> Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check never returned true prior to go1.16, because using DeepEqual on reflect.Value
return values checks their internal fields, and reflect.Zero included a unique unsafe pointer.
In go1.16, reflect.Zero started returning shared zero values, and this check started returning true.
However, requiring nullable on zero values is not correct. A zero value string "" should be valid even
if the schema does not allow the field to be null.
xref go-openapi/validate#138 and golang/go#43993 (comment)
/cc @sttts @apelisse