Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect zero value check #230

Merged
merged 1 commit into from
Mar 5, 2021

Commits on Mar 4, 2021

  1. Remove incorrect zero value check

    This check never returned true prior to go1.16, because using DeepEqual on reflect.Value
    return values checks their internal fields, and reflect.Zero included a unique unsafe pointer.
    
    In go1.16, reflect.Zero started returning shared zero values, and this check started returning true.
    
    However, requiring nullable on zero values is not correct. A zero value string "" should be valid even
    if the schema does not allow the field to be null.
    liggitt committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    e467f52 View commit details
    Browse the repository at this point in the history