Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rollout nil panice issue #25308

Merged
merged 1 commit into from
May 10, 2016
Merged

fix rollout nil panice issue #25308

merged 1 commit into from
May 10, 2016

Conversation

adohe-zz
Copy link

@adohe-zz adohe-zz commented May 7, 2016 •
edited by janetkuo
Loading

Pull Request Guidelines

  1. Please read our contributor guidelines.
  2. See our developer guide.
  3. Follow the instructions for labeling and writing a release note for this PR in the block below.
* Use the release-note-* labels to set the release note state 
* Clear this block to use the PR title as the release note 
-OR-
* Enter your extended release note here

Fixes #24606
Analytics

@adohe-zz
Copy link
Author

adohe-zz commented May 7, 2016

Please refer #24606 for more detail. @Kargakis @bgrant0607 ptal.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 7, 2016
@bgrant0607 bgrant0607 assigned janetkuo and unassigned bgrant0607 May 9, 2016
@janetkuo janetkuo added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 9, 2016
@janetkuo
Copy link
Member

janetkuo commented May 9, 2016

@adohe thanks for the fix!

@0xmichalis
Copy link
Contributor

lgtm

@k8s-bot
Copy link

k8s-bot commented May 10, 2016

GCE e2e build/test passed for commit d1480cd.

@janetkuo janetkuo added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 10, 2016
@fabioy fabioy merged commit a167a6b into kubernetes:master May 10, 2016
@adohe-zz adohe-zz deleted the deployment_panic branch May 11, 2016 00:47
@adohe-zz adohe-zz mentioned this pull request Jun 25, 2016
Closed
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@eparis eparis mentioned this pull request Aug 18, 2016
Closed
@ingvagabund ingvagabund mentioned this pull request Aug 19, 2016
Closed
@derekwaynecarr derekwaynecarr mentioned this pull request Aug 19, 2016
Merged
@ncdc ncdc mentioned this pull request Aug 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@adohe-zz @janetkuo @0xmichalis @k8s-bot @k8s-cherrypick-bot @googlebot @fabioy @bgrant0607 @k8s-github-robot @adohe