-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s v1.15-beta1: kubelet: unknown flag: --allow-privileged #4371
Comments
Deprecation notice for this flag: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.15.md#action-required If anyone wants to fix support for v1.15, here is where to get started:
This will need to be changed to a NewUnversionedOption() so that it isn't set for v1.15+. If Kubernetes v1.15.0-beta1 is working properly, the PR should also update NewestKubernetesVersion so that this release is tested in our integration tests: minikube/pkg/minikube/constants/constants.go Line 168 in b64f62c
|
Am I correct in understanding that I would have to remove the above line 245 which you have mentioned and add code similar to this so that this is set only for versions which support it? (Basically setting theLessThanOrEqual
|
I would like to provide PR for this ticket. Thanks @blueelvis @tstromberg |
Sometimes, minikube lags behind kubernetes which can lead to a breakage of the test suite, since minikube will fail to start with the latest kubernetes version. See for example [this issue](kubernetes/minikube#4371). This change defaults to leave the decision of which k8s version to use, to minikube itself. This is defined in: https://github.com/kubernetes/minikube/master/pkg/minikube/constants/constants.go However, if one really desires it is still possible to pass `--kubernetes-version=X.Y.Z` to minikube initialization start command via an environment variable before invoking the test suite: export $MINIKUBE_ARGS="--kubernetes-version=X.Y.Z" This allows ofcourse passing other flags to minikube also.
Kubernetes-1.15.0 unable to run on minikube 1.1.1 as this error still exists on last release. |
@the-redback Let me check. |
With latest code, minikube could start kubenetes-1.15.0 successfully, as below my test result: @the-redback I am worried the fixes was not in the build you are using, wish you could help double check. Thanks. |
@the-redback - minikube v1.2.0 with v1.15.0 support will be published this week. If you build from source code, v1.15.0 will work fine. |
Thanks @tstromberg . |
@fenglixa , It's strange see the log I am getting below:
I sshed into minikube to see the kubelet version:
|
@fenglixa, I see. you are using custom build instead of last stable release, right? That's what I was reporting in the first place. Then I got confused seeing your log. :) anyway, end of misunderstanding. I am okay to wait one more week for next release. :D |
Yes, I am using source code build, so from @tstromberg, this fix will be included in v1.2.0. |
minikube v1.2.0 is released, and defaults to Kubernetes v1.1.15. Thank you for your patience! |
Sometimes, minikube lags behind kubernetes which can lead to a breakage of the test suite, since minikube will fail to start with the latest kubernetes version. See for example [this issue](kubernetes/minikube#4371). This change defaults to leave the decision of which k8s version to use, to minikube itself. This is defined in: https://github.com/kubernetes/minikube/master/pkg/minikube/constants/constants.go However, if one really desires it is still possible to pass `--kubernetes-version=X.Y.Z` to minikube initialization start command via an environment variable before invoking the test suite: export $MINIKUBE_ARGS="--kubernetes-version=X.Y.Z" This allows ofcourse passing other flags to minikube also.
Sometimes, minikube lags behind kubernetes which can lead to a breakage of the test suite, since minikube will fail to start with the latest kubernetes version. See for example [this issue](kubernetes/minikube#4371). This change defaults to leave the decision of which k8s version to use, to minikube itself. This is defined in: https://github.com/kubernetes/minikube/master/pkg/minikube/constants/constants.go However, if one really desires it is still possible to pass `--kubernetes-version=X.Y.Z` to minikube initialization start command via an environment variable before invoking the test suite: export $MINIKUBE_ARGS="--kubernetes-version=X.Y.Z" This allows ofcourse passing other flags to minikube also.
Sometimes, minikube lags behind kubernetes which can lead to a breakage of the test suite, since minikube will fail to start with the latest kubernetes version. See for example [this issue](kubernetes/minikube#4371). This change defaults to leave the decision of which k8s version to use, to minikube itself. This is defined in: https://github.com/kubernetes/minikube/master/pkg/minikube/constants/constants.go However, if one really desires it is still possible to pass `--kubernetes-version=X.Y.Z` to minikube initialization start command via an environment variable before invoking the test suite: export $MINIKUBE_ARGS="--kubernetes-version=X.Y.Z" This allows ofcourse passing other flags to minikube also.
If
minikube start --kubernetes-version=v1.15.0-beta.1
is used, a failure occurs:The text was updated successfully, but these errors were encountered: