Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CRI config of NetworkPlugin and PauseImage #14703

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Handle CRI config of NetworkPlugin and PauseImage #14703

merged 1 commit into from
Mar 22, 2023

Conversation

afbjorklund
Copy link
Collaborator

These have been removed from the kubelet, and are supposed to be
handled by the CRI config. Remove the earlier Docker-only hacks.

This fixes the issue where kubeadm said 3.7, and docker ran 3.6...

k8s.gcr.io/pause:3.7
k8s.gcr.io/pause:3.6
k8s.gcr.io/kube-scheduler:v1.24.1
k8s.gcr.io/kube-proxy:v1.24.1
k8s.gcr.io/kube-controller-manager:v1.24.1
k8s.gcr.io/kube-apiserver:v1.24.1
k8s.gcr.io/etcd:3.5.3-0
k8s.gcr.io/coredns/coredns:v1.8.6
gcr.io/k8s-minikube/storage-provisioner:v5

Also removes the old flag, which avoids a warning from kubeadm

Flag --pod-infra-container-image has been deprecated, will be removed in 1.27. Image garbage collector will get sandbox image information from CRI.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@afbjorklund afbjorklund mentioned this pull request Aug 2, 2022
Closed
@afbjorklund afbjorklund linked an issue Aug 2, 2022 that may be closed by this pull request
start failure in qemu, need k8s.gcr.io/pause:3.6 not 3.7 #14641
Closed
@afbjorklund

This comment was marked as outdated.

Sign in to view
This was referenced Aug 4, 2022
Merged
Closed
@afbjorklund afbjorklund linked an issue Aug 4, 2022 that may be closed by this pull request
cri-dockerd v0.2.4 does not work out of the box with minikube #14724
Closed
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 5, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14703) |
+----------------+----------+---------------------+
| minikube start | 57.0s    | 53.6s               |
| enable ingress | 27.6s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 56.9s 55.6s 58.3s 56.1s 58.3s
Times for minikube (PR 14703) start: 52.0s 53.0s 53.9s 53.1s 56.0s

Times for minikube ingress: 29.6s 28.6s 25.1s 29.1s 25.6s
Times for minikube (PR 14703) ingress: 29.1s 26.2s 29.1s 30.6s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14703) |
+----------------+----------+---------------------+
| minikube start | 28.1s    | 25.3s               |
| enable ingress | 23.6s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 22.6s 23.5s 27.0s 22.5s
Times for minikube (PR 14703) ingress: 23.0s 21.5s 23.0s 23.0s 26.5s

Times for minikube start: 28.5s 27.9s 28.6s 27.6s 28.1s
Times for minikube (PR 14703) start: 25.2s 25.1s 25.0s 26.1s 25.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14703) |
+----------------+----------+---------------------+
| minikube start | 28.1s    | 23.5s               |
| enable ingress | 29.4s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.3s 34.3s 24.1s 23.5s 35.2s
Times for minikube (PR 14703) start: 23.7s 23.8s 23.2s 22.9s 23.7s

Times for minikube ingress: 27.5s 37.5s 26.9s 27.5s 27.5s
Times for minikube (PR 14703) ingress: 27.0s 27.5s 27.4s 26.9s 27.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnlyKic (gopogh) 7.59 (chart)
Docker_macOS TestDownloadOnly/v1.24.3/preload-exists (gopogh) 9.65 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 12.33 (chart)
Docker_Windows TestAddons/Setup (gopogh) 54.49 (chart)
Docker_Windows TestCertOptions (gopogh) 54.49 (chart)
Docker_Windows TestDockerFlags (gopogh) 54.49 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 54.49 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 54.49 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/MySQL (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/NodeLabels (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/PersistentVolumeClaim (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/SSHCmd (gopogh) 54.49 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 54.49 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@afbjorklund afbjorklund mentioned this pull request Aug 21, 2022
Closed
@tankilo
Copy link

tankilo commented Sep 3, 2022

Expect this PR to be merged. I come across this probelm similar to #14624.

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Sep 3, 2022 •
edited
Loading

The workaround before it is merged is: minikube start --enable-default-cni

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error downloading artifacts: artifact download start: exit status 109docker driver with docker runtime
error downloading artifacts: artifact download start: exit status 81docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) n/a
Docker_macOS TestFunctional/parallel/TunnelCmd/serial (gopogh) n/a
Docker_Linux_containerd TestKicCustomNetwork/create_custom_network (gopogh) 0.00 (chart)
Docker_Linux_containerd TestKicCustomNetwork/use_default_bridge_network (gopogh) 0.00 (chart)
Docker_Linux_containerd TestKicCustomSubnet (gopogh) 0.00 (chart)
Docker_Linux_containerd TestKicExistingNetwork (gopogh) 0.00 (chart)
Docker_macOS TestAddons/Setup (gopogh) 0.00 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/AddonsCmd (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/CpCmd (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/DryRun (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/InternationalLanguage (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/NodeLabels (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ProfileCmd/profile_json_output (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ProfileCmd/profile_list (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ProfileCmd/profile_not_create (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/StatusCmd (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@mgabeler-lee-6rs
Copy link

My earlier typo fix got lost in the rebase

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Nov 7, 2022

if it doesnt break any test looks good to me,

@mgabeler-lee-6rs
Copy link

This PR is broken in its current form, see my earlier comment

@afbjorklund afbjorklund mentioned this pull request Nov 9, 2022
Closed
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14703) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 51.4s               |
| enable ingress | 27.7s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.2s 26.7s 28.6s 28.7s 29.2s
Times for minikube (PR 14703) ingress: 25.7s 28.1s 29.7s 29.6s 25.2s

Times for minikube start: 52.2s 52.9s 54.1s 53.9s 53.7s
Times for minikube (PR 14703) start: 50.5s 51.2s 53.3s 52.4s 49.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14703) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 23.0s               |
| enable ingress | 22.2s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 25.8s 26.4s 24.8s 25.5s 26.5s
Times for minikube (PR 14703) start: 22.4s 22.9s 25.2s 22.3s 22.3s

Times for minikube ingress: 23.0s 22.5s 21.5s 22.5s 21.5s
Times for minikube (PR 14703) ingress: 22.0s 22.0s 23.5s 23.4s 22.5s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14703) |
+-------------------+----------+---------------------+
| minikube start    | 23.4s    | 25.4s               |
| ⚠️  enable ingress | 27.4s    | 39.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 14703) start: 22.2s 24.9s 21.7s 35.8s 22.3s
Times for minikube start: 22.0s 25.2s 21.9s 23.1s 24.8s

Times for minikube ingress: 27.4s 27.5s 27.0s 27.4s 27.4s
Times for minikube (PR 14703) ingress: 27.0s 27.4s 26.9s 57.5s 58.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestRunningBinaryUpgrade (gopogh) 1.24 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 23.40 (chart)
Docker_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 26.28 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 33.56 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 38.14 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 38.14 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 38.14 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 38.69 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 39.17 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 40.68 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 41.18 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 41.67 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 41.67 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 48.31 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 49.17 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 49.59 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 50.36 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 50.41 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 62.50 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 72.58 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 76.15 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 80.54 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 80.54 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 83.22 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 83.89 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 84.56 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 95.76 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_Linux_containerd TestPreload (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@mgabeler-lee-6rs mgabeler-lee-6rs mentioned this pull request Dec 20, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2023
@afbjorklund
Handle CRI config of NetworkPlugin and PauseImage
2624a19 
These have been removed from the kubelet, and are supposed to be
handled by the CRI config. Remove the earlier Docker-only hacks.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2023
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 7.32 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 72.73 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 72.73 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 519e2aa into kubernetes:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgabeler-lee-6rs mgabeler-lee-6rs mgabeler-lee-6rs left review comments

@medyagh medyagh medyagh approved these changes

@spowelljr spowelljr Awaiting requested review from spowelljr

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@afbjorklund @minikube-pr-bot @tankilo @mgabeler-lee-6rs @k8s-ci-robot @medyagh