Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-dockerd 0.2.6 #14827

Closed
wants to merge 5 commits into from
Closed

cri-dockerd 0.2.6 #14827

wants to merge 5 commits into from

Conversation

afbjorklund
Copy link
Collaborator

  • go1.19

  • Use cni by default on Linux, too

Note: needs fix for --network-plugin to go in first:

@afbjorklund afbjorklund added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2022
@afbjorklund
Copy link
Collaborator Author

@spowelljr : it was not entirelly obvious how to kick off the build of the new binaries, so just updated version and checksums

@afbjorklund

This comment was marked as outdated.

Sign in to view
@spowelljr
Copy link
Member

@spowelljr : it was not entirelly obvious how to kick off the build of the new binaries, so just updated version and checksums

No worries, I just ran the job

@spowelljr
Copy link
Member

ok-to-build-iso

@spowelljr
Copy link
Member

ok-to-build-image

@minikube-bot

This comment was marked as outdated.

Sign in to view
@spowelljr
Copy link
Member

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2022
@minikube-bot

This comment was marked as outdated.

Sign in to view
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022
@afbjorklund afbjorklund changed the title cri-dockerd 0.2.5 cri-dockerd 0.2.6 Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2022
@spowelljr
Copy link
Member

ok-to-build-image

@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2022
This was referenced Nov 6, 2022
Closed
Closed
@cdeeran
Copy link

cdeeran commented Dec 1, 2022

Commenting to subscribe to the PR. I really need this to go through in order to advance on my project.

afbjorklund and others added 4 commits December 11, 2022 13:00
@afbjorklund
Fix usage of version and commit for cri-dockerd
f15652b 
The commit is only needed for patching, but leave it for now.

Make sure to use the version too, in the cri-dockerd command.
@afbjorklund
Upgrade cri-dockerd from 0.2.2 to 0.2.5
fb32168
@afbjorklund
Upgrade cri-dockerd from 0.2.5 to 0.2.6
91d8927
@spowelljr @afbjorklund
ran cri-dockerd build
8a9f917
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@afbjorklund
Copy link
Collaborator Author

ok-to-build-image

@afbjorklund afbjorklund removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2022
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14827) |
+----------------+----------+---------------------+
| minikube start | 53.9s    | 53.8s               |
| enable ingress | 27.8s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 55.0s 52.9s 54.4s 53.1s 53.9s
Times for minikube (PR 14827) start: 52.4s 54.1s 52.4s 55.1s 54.8s

Times for minikube ingress: 27.6s 28.6s 29.6s 28.2s 25.2s
Times for minikube (PR 14827) ingress: 28.1s 28.1s 29.2s 27.6s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14827) |
+----------------+----------+---------------------+
| minikube start | 25.4s    | 25.1s               |
| enable ingress | 25.4s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 26.1s 24.7s 25.4s 25.9s 25.0s
Times for minikube (PR 14827) start: 24.7s 25.3s 24.7s 25.4s 25.3s

Times for minikube ingress: 19.9s 18.9s 48.9s 20.0s 19.5s
Times for minikube (PR 14827) ingress: 20.9s 49.4s 22.0s 21.0s 20.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14827) |
+-------------------+----------+---------------------+
| minikube start    | 22.3s    | 21.8s               |
| ⚠️  enable ingress | 26.6s    | 32.6s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 21.3s 22.5s 22.0s 21.6s 24.0s
Times for minikube (PR 14827) start: 22.2s 21.4s 21.9s 21.6s 21.8s

Times for minikube ingress: 25.9s 26.5s 27.4s 26.4s 26.5s
Times for minikube (PR 14827) ingress: 26.5s 26.4s 25.9s 26.5s 57.5s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14827) |
+----------------+----------+---------------------+
| minikube start | 54.0s    | 54.1s               |
| enable ingress | 29.1s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.7s 29.7s 29.3s 28.2s 28.7s
Times for minikube (PR 14827) ingress: 28.7s 28.7s 28.7s 29.3s 28.2s

Times for minikube start: 52.9s 53.9s 54.0s 55.6s 53.5s
Times for minikube (PR 14827) start: 53.6s 54.8s 52.6s 56.8s 52.6s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube (PR 14827): timing cmd: [/home/jenkins/.minikube/minikube-binaries/14827/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) n/a
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 3.14 (chart)
Docker_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 16.54 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 16.67 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 39.09 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 39.09 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 39.09 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 40.91 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 40.91 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 40.91 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 41.23 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 41.96 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 49.09 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 49.09 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 50.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 50.88 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 60.67 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 70.16 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 70.18 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 73.94 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 79.58 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 80.28 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 80.28 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 83.80 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 96.36 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestFunctional/parallel (gopogh) n/a
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) n/a
Docker_Windows TestMultiNode/serial/StartAfterStop (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) n/a
Docker_Windows TestPause/serial/Pause (gopogh) n/a
Docker_Cloud_Shell TestAddons/Setup (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/StartWithProxy (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/FirstStart (gopogh) 0.00 (chart)
Docker_macOS TestOffline (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/SoftStart (gopogh) 0.64 (chart)
Docker_macOS TestAddons/Setup (gopogh) 0.65 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 0.65 (chart)
Docker_macOS TestFunctional/parallel/CertSync (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/CpCmd (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/FileSync (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 0.67 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.67 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

This was referenced Dec 14, 2022
Closed
Merged
@mgabeler-lee-6rs mgabeler-lee-6rs mentioned this pull request Dec 20, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

@afbjorklund: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spowelljr spowelljr mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr Awaiting requested review from spowelljr

@klaases klaases Awaiting requested review from klaases

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afbjorklund @k8s-ci-robot @spowelljr @minikube-bot @minikube-pr-bot @cdeeran